Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.5] [Task manager] Adds ensureScheduling api to allow safer rescheduling of existing tasks (#50232) #51796

Closed
wants to merge 1 commit into from

Conversation

gmmorris
Copy link
Contributor

Backports the following commits to 7.5:

…of existing tasks (elastic#50232)

Adds an ensureScheduling api to Task Manager which allow safer rescheduling of existing tasks by handling the case where a Task with a known ID is scheduled and clashes with an existing schedule of that same task.
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@gmmorris
Copy link
Contributor Author

Holding off on merging this to avoid adding last minute non critical features into 7.5 moments before release

@gmmorris gmmorris closed this Nov 27, 2019
@ycombinator
Copy link
Contributor

Hey @gmmorris Now that 7.5.0 has been released, could we resurrect this PR and merge it into 7.5? Context: following the conversation in https://github.com/elastic/elastic-stack-testing/pull/451.

@gmmorris
Copy link
Contributor Author

gmmorris commented Dec 3, 2019

Hey @ycombinator, after discussing the size of this PR there seemed to be a feeling that as an enhancement it's too big to be pulled into a patch version.
Since this backport was discussed in order to address how Telemetry handles the error returned by Task Manager, the best approach would be for this to be patched within Telemetry.
I believe @Bamieh has thoughts on the topic.

@cachedout
Copy link
Contributor

I believe @Bamieh has thoughts on the topic.

Hi @Bamieh! Do you have suggestions here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants