Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Improve Percy functional tests #51699

Merged
merged 4 commits into from
Nov 28, 2019
Merged

[Discover] Improve Percy functional tests #51699

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0630d97
Implement new wait for chart rendered function
kertal Nov 21, 2019
9f9b6b7
Add findByCssSelector to ensure the charts have been rendered
kertal Nov 26, 2019
0abc77b
Cleanup unused waitUntilHistogramIsRendered
kertal Nov 26, 2019
40c8b10
Merge branch 'master' into kertal-pr-2019-11-21-percy-improvements
elasticmachine Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/visual_regression/tests/discover/chart_visualization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export default function ({ getService, getPageObjects }) {
const kibanaServer = getService('kibanaServer');
const PageObjects = getPageObjects(['common', 'discover', 'header', 'timePicker']);
const visualTesting = getService('visualTesting');
const find = getService('find');
const defaultSettings = {
defaultIndex: 'logstash-*',
'discover:sampleSize': 1
Expand All @@ -48,10 +49,12 @@ export default function ({ getService, getPageObjects }) {

describe('query', function () {
this.tags(['skipFirefox']);
let renderCounter = 0;

it('should show bars in the correct time zone', async function () {
await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
await PageObjects.discover.waitUntilSearchingHasFinished();
await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change, but maybe it is good to wrap it in service since elastic-charts will be used in multiple viz across Kibana. Then we can re-use functions in multiple tests 8d82ba6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suite may look like da4f78a

await visualTesting.snapshot({
show: ['discoverChart'],
});
Expand All @@ -61,6 +64,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.discover.setChartInterval('Hourly');
await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
await visualTesting.snapshot({
show: ['discoverChart'],
});
Expand All @@ -70,6 +74,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.discover.setChartInterval('Daily');
await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
await visualTesting.snapshot({
show: ['discoverChart'],
});
Expand All @@ -79,6 +84,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.discover.setChartInterval('Weekly');
await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
await visualTesting.snapshot({
show: ['discoverChart'],
});
Expand All @@ -92,6 +98,7 @@ export default function ({ getService, getPageObjects }) {
});
await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
await PageObjects.discover.waitUntilSearchingHasFinished();
await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
await visualTesting.snapshot({
show: ['discoverChart'],
});
Expand All @@ -101,6 +108,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.discover.setChartInterval('Monthly');
await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
await visualTesting.snapshot({
show: ['discoverChart'],
});
Expand All @@ -110,6 +118,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.discover.setChartInterval('Yearly');
await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
await visualTesting.snapshot({
show: ['discoverChart'],
});
Expand All @@ -119,6 +128,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.discover.setChartInterval('Auto');
await find.byCssSelector(`.echChart[data-ech-render-count="${++renderCounter}"]`);
await visualTesting.snapshot({
show: ['discoverChart'],
});
Expand Down