-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] DF Analytics Outlier detection results - add search bar #51235
Merged
alvarezmelissa87
merged 4 commits into
elastic:master
from
alvarezmelissa87:ml-outlier-detection-results-search-bar
Nov 22, 2019
Merged
[ML] DF Analytics Outlier detection results - add search bar #51235
alvarezmelissa87
merged 4 commits into
elastic:master
from
alvarezmelissa87:ml-outlier-detection-results-search-bar
Nov 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:enhancement
:ml
v8.0.0
Feature:Data Frame Analytics
ML data frame analytics features
v7.6.0
labels
Nov 20, 2019
alvarezmelissa87
requested review from
walterra,
darnautov,
peteharverson and
jgowdyelastic
November 20, 2019 21:44
Pinging @elastic/ml-ui (:ml) |
💔 Build Failed
|
peteharverson
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
💚 Build Succeeded
|
walterra
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alvarezmelissa87
force-pushed
the
ml-outlier-detection-results-search-bar
branch
from
November 21, 2019 19:43
a8ba3b1
to
8028da4
Compare
💔 Build Failed |
💚 Build Succeeded |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Nov 22, 2019
…#51235) * add search bar to outlierDetection results table * show empty results error message in table so user can retry query * remove unused translation * type updates after branch update
alvarezmelissa87
added a commit
that referenced
this pull request
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Data Frame Analytics
ML data frame analytics features
:ml
release_note:enhancement
v7.6.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds search bar to outlier detection results table.
No returned results message now shown in table so user can try another query.
Parsing errors are also shown in the table.
Note:
#50991 will need to be merged in first as there will be conflicts since some of the same files are touched. I'll then resolve the conflicts before merging this PR.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately