Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] DF Analytics Outlier detection results - add search bar #51235

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Nov 20, 2019

Summary

Adds search bar to outlier detection results table.

image

No returned results message now shown in table so user can try another query.

image

Parsing errors are also shown in the table.

image

Note:

#50991 will need to be merged in first as there will be conflicts since some of the same files are touched. I'll then resolve the conflicts before merging this PR.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-outlier-detection-results-search-bar branch from a8ba3b1 to 8028da4 Compare November 21, 2019 19:43
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alvarezmelissa87 alvarezmelissa87 merged commit af19e9d into elastic:master Nov 22, 2019
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Nov 22, 2019
…#51235)

* add search bar to outlierDetection results table

* show empty results error message in table so user can retry query

* remove unused translation

* type updates after branch update
@alvarezmelissa87 alvarezmelissa87 deleted the ml-outlier-detection-results-search-bar branch November 22, 2019 14:19
alvarezmelissa87 added a commit that referenced this pull request Nov 22, 2019
…#51441)

* add search bar to outlierDetection results table

* show empty results error message in table so user can retry query

* remove unused translation

* type updates after branch update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants