Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove unused Angular filter definitions #51027

Merged
merged 2 commits into from
Nov 20, 2019
Merged

[ML] Remove unused Angular filter definitions #51027

merged 2 commits into from
Nov 20, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Nov 19, 2019 •
edited
Loading

Summary

Removes the last two (unused) Angular filter definitions from the ML codebase - metricChangeDescription and formatValue. These formatters are no longer used anywhere as Angular filters.

Also converts the remaining formatters to TypeScript, and switches the test files to Jest:

  • formatters/abbreviate_whole_number
  • formatters/format_value
  • formatter/metric_change_description

Addresses the Angular filter items in #18374

Checklist

@peteharverson peteharverson added review :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Nov 19, 2019
@peteharverson peteharverson requested a review from a team as a code owner November 19, 2019 12:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

alvarezmelissa87
alvarezmelissa87 approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

walterra
walterra approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit cdc9caa into elastic:master Nov 20, 2019
@peteharverson peteharverson deleted the ml-remove-angular-filters branch November 20, 2019 12:14
@peteharverson peteharverson mentioned this pull request Nov 20, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Nov 20, 2019
@peteharverson
[ML] Remove unused Angular filters (elastic#51027)
a6e35b3
peteharverson added a commit that referenced this pull request Nov 20, 2019
@peteharverson
[ML] Remove unused Angular filters (#51027) (#51154)
0aa516e
@elasticmachine elasticmachine mentioned this pull request Nov 20, 2019
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees
No one assigned
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes review v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87 @jgowdyelastic