Default search params for ignore_unavailable and rest_total_hits_as_int #50953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Feature:Search
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
4 tasks
💔 Build Failed |
stacey-gammon
approved these changes
Nov 18, 2019
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Nov 26, 2019
…nt (elastic#50953) * Default search params for ignore_unavailable and rest_total_hits_as_int * Update code with options arg * Fix filter matches index for filters with partial meta * Fix tests
|
7.x (7.6.0): 3b1e06f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds defaults to the new search service:
ignore_unavailable:true, so search requests against missing indices return an empty result rather than failingrest_total_hits_as_int:true, so that the total number of hits is returned as a number rather than a rangeSee https://www.elastic.co/guide/en/elasticsearch/reference/7.4/search-search.html for a description of these Elasticsearch parameters.
Checklist