Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Set no of ticks based on available width for chart #50904

Merged
merged 1 commit into from
Nov 19, 2019
Merged

[APM] Set no of ticks based on available width for chart #50904

merged 1 commit into from
Nov 19, 2019

Conversation

dgieselaar
Copy link
Member

Closes #50888.

Went for a slightly different approach then suggested, as width is already available in getPlotUtils, we can just use that to determine what to pass to ticks(). Might be missing something though, LMK.

@dgieselaar dgieselaar requested a review from a team as a code owner November 18, 2019 13:20
@dgieselaar dgieselaar added release_note:fix Team:APM All issues that need APM UI Team support v7.6.0 labels Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar dgieselaar removed the Team:APM All issues that need APM UI Team support label Nov 18, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

sorenlouv
sorenlouv approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@dgieselaar dgieselaar merged commit 6fc04d2 into elastic:master Nov 19, 2019
@dgieselaar dgieselaar deleted the dynamic-ticks branch November 19, 2019 16:11
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Nov 19, 2019
@dgieselaar
[APM] Set no of ticks based on available width for chart (elastic#50904)
3ec9fdb 
Closes elastic#50888.
@dgieselaar dgieselaar mentioned this pull request Nov 19, 2019
Merged
@cauemarcondes
Copy link
Contributor

Tests:
Chrome: ✅
Firefox: ✅
Safari: ✅
IE: ⚠️ doesn't block RC: #55362

@cauemarcondes cauemarcondes added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:fix v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] X-axis ticks overlap on small screen sizes
5 participants
@dgieselaar @elasticmachine @cauemarcondes @sorenlouv @ogupte