Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Enabling lat_long detector function in advanced wizard #50787

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 15, 2019

Enabling the lat_long detector function in the advanced wizard for fields of type geo_point and geo_shape

2019-11-15 16-16-56 2019-11-15 16_19_13

Fixes #50502

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member Author

cc @benwtrent

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it highlights issues with the formatting of actual / typical values, and the empty actions menu, in the anomalies table for lat_long detectors. We should address this in a follow-up.

image

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit 6bdcb23 into elastic:master Nov 18, 2019
@jgowdyelastic jgowdyelastic deleted the enabling-lat_long-in-advanced-wizard branch November 18, 2019 10:31
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Nov 18, 2019
…50787)

* [ML] Enabling lat_long agg in advanced wizard

* fixing tests
jgowdyelastic added a commit that referenced this pull request Nov 18, 2019
…50890)

* [ML] Enabling lat_long agg in advanced wizard

* fixing tests
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Dec 4, 2019
…50787)

* [ML] Enabling lat_long agg in advanced wizard

* fixing tests
jgowdyelastic added a commit that referenced this pull request Dec 4, 2019
…52180)

* [ML] Enabling lat_long agg in advanced wizard

* fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Job wizard lat_long detector
5 participants