Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds route context for spaces #50774

Closed
wants to merge 1 commit into from
Closed

Adds route context for spaces #50774

wants to merge 1 commit into from
+68 −0

Conversation

legrego
Copy link
Member

@legrego legrego commented Nov 15, 2019 •
edited
Loading

Summary

This adds a minimal spaces route context for NP routes. It allows consumers to retrieve the current space id based on the current request.

This PR doesn't introduce any substantial code, it just exposes the existing spacesService.getSpaceId() to the request context.

Related: #50444, #50224

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Spaces Platform Security - Spaces feature v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.6.0 labels Nov 15, 2019
@legrego legrego requested a review from a team as a code owner November 15, 2019 13:42
@legrego legrego mentioned this pull request Nov 15, 2019
Merged
5 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

jportner
jportner approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legrego
Copy link
Member Author

legrego commented Dec 17, 2019

I'm not sure this is still needed; Closing for now, but happy to re-open if the need arises.

@legrego legrego closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
Feature:NP Migration Feature:Security/Spaces Platform Security - Spaces feature release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legrego @elasticmachine @jportner