Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip-ci] Replace coordinate map in Kibana getting started docs with Maps #50167

Merged
merged 9 commits into from
Nov 11, 2019
Merged

[skip-ci] Replace coordinate map in Kibana getting started docs with Maps #50167

merged 9 commits into from
Nov 11, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 11, 2019 •
edited
Loading

This PR updates the Kibana getting started docs. It replaces coordinate map with Maps, https://www.elastic.co/guide/en/kibana/current/tutorial-visualizing.html#tutorial-visualize-map.

@nreese nreese requested a review from gchaps November 11, 2019 16:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@nreese nreese added the release_note:skip Skip the PR/issue when compiling release notes label Nov 11, 2019
gchaps
gchaps reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I added the map to the dashboard, it did not have any data. Is it because the time filter is set to the last 15 minutes?

docs/getting-started/tutorial-visualizing.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/tutorial-visualizing.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/tutorial-visualizing.asciidoc
. Set the vector style.
.. For *Fill color*, select the yellow to red color ramp.
.. For *Border color*, select white.
.. Click *Save & close*.
+
The map now looks like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to click "Refresh" for the data to show.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style settings should be applied immediately

docs/getting-started/tutorial-visualizing.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/tutorial-visualizing.asciidoc Outdated Show resolved Hide resolved
@nreese
Copy link
Contributor Author

nreese commented Nov 11, 2019

When I added the map to the dashboard, it did not have any data. Is it because the time filter is set to the last 15 minutes?

Yes, the dashboard time picker will need to be set to the time range.

@nreese nreese requested a review from gchaps November 11, 2019 18:58
gchaps
gchaps reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove the word "coordinate" from this bulleted list:

Screen Shot 2019-11-11 at 11 27 19 AM

I needed to click Refresh after I changed the time filter in the dashboard.

My map doesn't look like what I see in the tutorial:

Screen Shot 2019-11-11 at 11 36 22 AM

@nreese
Copy link
Contributor Author

nreese commented Nov 11, 2019

Do we need to remove the word "coordinate" from this bulleted list

Thanks, updated text in list

I needed to click Refresh after I changed the time filter in the dashboard

Thanks, added step about clicking Update button when setting time filter

My map doesn't look like what I see in the tutorial

I had zoomed the map in to make a more interesting screen shot. Should I just use the one you provided?

@nreese nreese requested a review from gchaps November 11, 2019 20:51
gchaps
gchaps approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your image is fine as is. LGTM.

@nreese nreese merged commit 9fdbf82 into elastic:master Nov 11, 2019
nreese added a commit to nreese/kibana that referenced this pull request Nov 11, 2019
@nreese
[skip-ci] Replace coordinate map in Kibana getting started docs with …
6fe5747 
…Maps (elastic#50167)

* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
@nreese nreese mentioned this pull request Nov 11, 2019
Merged
nreese added a commit to nreese/kibana that referenced this pull request Nov 11, 2019
@nreese
[skip-ci] Replace coordinate map in Kibana getting started docs with …
6605843 
…Maps (elastic#50167)

* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
@nreese nreese mentioned this pull request Nov 11, 2019
Merged
nreese added a commit to nreese/kibana that referenced this pull request Nov 11, 2019
@nreese
[skip-ci] Replace coordinate map in Kibana getting started docs with …
c365c49 
…Maps (elastic#50167)

* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
@nreese nreese mentioned this pull request Nov 11, 2019
Merged
nreese added a commit to nreese/kibana that referenced this pull request Nov 11, 2019
@nreese
[skip-ci] Replace coordinate map in Kibana getting started docs with …
ad4aa95 
…Maps (elastic#50167)

* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
@nreese nreese mentioned this pull request Nov 11, 2019
Merged
nreese added a commit that referenced this pull request Nov 12, 2019
@nreese
[skip-ci] Replace coordinate map in Kibana getting started docs with …
96e256a 
…Maps (#50167) (#50225)

* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
nreese added a commit that referenced this pull request Nov 12, 2019
@nreese
[skip-ci] Replace coordinate map in Kibana getting started docs with …
bdfe2df 
…Maps (#50167) (#50226)

* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
nreese added a commit that referenced this pull request Nov 12, 2019
@nreese
[skip-ci] Replace coordinate map in Kibana getting started docs with …
7e3b51e 
…Maps (#50167) (#50227)

* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
nreese added a commit that referenced this pull request Nov 12, 2019
@nreese
[skip-ci] Replace coordinate map in Kibana getting started docs with …
447c8b3 
…Maps (#50167) (#50228)

* [Maps] replace coordinate map with Elastic Maps in Kibana getting started docs

* update dashboard getting started page

* update screen shot

* Update docs/getting-started/tutorial-visualizing.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

* update dashboard instructions to include step to set time fitler

* clean up more instances for vector style

* review feedback
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into test-1
37d4836 
* upstream/master:
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into test-3
7b512ad 
* upstream/master:
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into np-migration/ua […
faa2676 
…skip ci]

* upstream/master:
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.3.0 v7.4.0 v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nreese @elasticmachine @gchaps