[Discover] Close filter popup on click outside #49934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
added
release_note:skip
majagrubic
force-pushed
the
maja/discover-close-popover
branch
from
ac2539d to
1b0643e
Compare
|
cc @ryankeairns |
💔 Build Failed |
💔 Build Failed |
ryankeairns
approved these changes
Nov 1, 2019
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
kertal
approved these changes
Nov 4, 2019
|
@elasticmachine merge upstream |
💚 Build Succeeded |
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Nov 12, 2019
majagrubic
pushed a commit
that referenced
this pull request
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #48452.
Click outside the popover closes the popover (like in Lens).
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers