[Canvas] Use compressed forms in sidebar #49419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankeairns
added
release_note:enhancement
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
💔 Build Failed
|
|
Moving this out of draft, but I will need some help sorting out the functional tests. |
ryankeairns
force-pushed
the
rk/43807-canvas-compressed
branch
from
ca2e9e0 to
6f3296b
Compare
💔 Build Failed
|
💔 Build Failed
|
💔 Build Failed
|
💚 Build Succeeded
|
poffdeluxe
approved these changes
Oct 29, 2019
x-pack/legacy/plugins/canvas/canvas_plugin_src/uis/datasources/demodata.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/canvas/public/components/datasource/datasource.scss
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/canvas/public/components/datasource/datasource_selector.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
|
cqliu1
reviewed
Oct 30, 2019
x-pack/legacy/plugins/canvas/canvas_plugin_src/uis/arguments/axis_config/extended_template.tsx
Outdated
Show resolved
Hide resolved
cqliu1
reviewed
Oct 30, 2019
x-pack/legacy/plugins/canvas/canvas_plugin_src/uis/arguments/filter_group.js
Outdated
Show resolved
Hide resolved
💔 Build Failed
|
ryankeairns
force-pushed
the
rk/43807-canvas-compressed
branch
from
4928bf6 to
921ecc1
Compare
💚 Build Succeeded
|
cqliu1
reviewed
Oct 31, 2019
x-pack/legacy/plugins/canvas/public/expression_types/arg_types/series_style/simple_template.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
|
cqliu1
approved these changes
Nov 1, 2019
ryankeairns
force-pushed
the
rk/43807-canvas-compressed
branch
from
e6e9fa2 to
d96d75a
Compare
💔 Build Failed
|
💔 Build Failed
|
ryankeairns
force-pushed
the
rk/43807-canvas-compressed
branch
from
d96d75a to
400e3bc
Compare
💔 Build Failed
|
|
jenkins test this |
💔 Build Failed
|
ryankeairns
force-pushed
the
rk/43807-canvas-compressed
branch
from
400e3bc to
0abc87f
Compare
💔 Build Failed |
💚 Build Succeeded |
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Nov 15, 2019
* compressed sidebar design * add back metric help, style no datasource msg * re-style remove button * re-style element status section * remove unused component import * update storyshots * clean up unused i18n values * address feedback * address i81n feedback * update storyshot * convert string to i18n * style grouped sidebar messages * update storyshots
ryankeairns
added a commit
that referenced
this pull request
Nov 15, 2019
* compressed sidebar design * add back metric help, style no datasource msg * re-style remove button * re-style element status section * remove unused component import * update storyshots * clean up unused i18n values * address feedback * address i81n feedback * update storyshot * convert string to i18n * style grouped sidebar messages * update storyshots
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...
|
@ryankeairns how do I test this PR please? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By using compressed form styles in the sidebar, element settings become more discoverable as less inputs move off the screen. To further simply this work area, help text has been moved to icon tooltips, amd text copy (including callouts, titles, etc.) has been edited to be more concise.
Other small UX improvements were made along the way, particularly within the Data tab (selecting datasources). This includes not only improved form layouts, but re-ordered fields, new card designs, additional contextual help (e.g. link to ES SQL docs) and more.
Previews
Follow-up PRs
There are a few things that I'd like to tackle subsequent to this PR:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers