Revert npm3, go back to npm2 #4939

rashidkpc · 2015-09-14T20:42:25Z

This reverts #4768
Fixes #4842

It also effectively fixes this, which was caused by the change to NPM3: #4842

w33ble · 2015-09-14T20:45:00Z

package.json

@@ -168,6 +168,6 @@
  },
  "engines": {
    "node": "2.5",
-    "npm": "3.2"
+    "npm": ">=2"


This still matches npm 3, no? We should probably lock in the version we expect, or at least use 2.x

rashidkpc · 2015-09-14T21:10:12Z

This currently passes tests, but doesn't actually build

Error: Cannot find module 'regenerator/runtime'

The npm shrinkwrap that we generate during build in order to package with distributions is now properly created based on the built dependencies rather than the local dev install.

Create shrinkwrap from build

spalger · 2015-09-17T21:31:15Z

For posterity:

npm install -g [email protected]
npm rebuild -g
rm -rf node_modules
npm install

spalger · 2015-09-17T21:49:50Z

@epixa the build now has a package.json and npm-shrinkwrap.json that match, but the actual node_modules directory does not.

Since we are running the clean:deepModules task after we npm shrinkwrap we invalidate the shrinkwrap file by modifying the node_modules directory.

To fix this I thought maybe npm would let us generate the shrinkwrap file using our modified node_modules directory, but that does not work according to my test:

grunt build
cd target
unzip kibana-4.2.0-snapshot-darwin-x64.zip
cd kibana-4.2.0-snapshot-darwin-x64
rm npm-shrinkwrap.json
npm shrinkwrap

output:

epixa · 2015-09-17T21:54:17Z

Good catch. I'm not sure if there is any practical solution to this using npm 2 at this point. I vote for removing the shrinkwrap from the build entirely. Any objections?

spalger · 2015-09-17T21:54:45Z

No objection here

We're not maintaining the shrinkwrap as part of the repo, and it doesn't add any value when being generated automatically as part of our build process. In its current form, it actually makes it so we cannot successfully create new builds without manually setting up a local shrinkwrap first.

epixa · 2015-09-17T21:59:14Z

@rashidkpc I issued another PR to this branch to remove the shrinkwrap entirely rashidkpc#6

Remove npm shrinkwrap tasks

spalger · 2015-09-17T22:39:14Z

Travis had some trouble an hour ago and they say the queue to start new jobs is really backed up. This test was supposed to start 30 minutes ago but since the Jenkins one passed I'm calling it good (the previous failures were all build related, which is Jenkins only)

LGTM

Revert npm3, go back to npm2

Revert npm3, go back to npm2

b7e667d

rashidkpc added review v4.2.0 labels Sep 14, 2015

w33ble reviewed Sep 14, 2015
View reviewed changes

fix node and npm versions in package.json

62a136c

rashidkpc assigned BigFunger Sep 14, 2015

epixa assigned epixa and unassigned BigFunger Sep 17, 2015

epixa and others added 2 commits September 17, 2015 16:28

Create shrinkwrap from build

690d204

The npm shrinkwrap that we generate during build in order to package with distributions is now properly created based on the built dependencies rather than the local dev install.

Merge pull request #5 from epixa/fix-shrinkwrap

44bfe2b

Create shrinkwrap from build

epixa assigned spalger and unassigned epixa Sep 17, 2015

spalger assigned epixa and unassigned spalger Sep 17, 2015

epixa assigned rashidkpc and unassigned epixa Sep 17, 2015

Merge pull request #6 from epixa/remove-shrinkwrap

2a4771d

Remove npm shrinkwrap tasks

spalger added a commit that referenced this pull request Sep 17, 2015

Merge pull request #4939 from rashidkpc/revert/npm3

1e3dd08

Revert npm3, go back to npm2

spalger merged commit 1e3dd08 into elastic:master Sep 17, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert npm3, go back to npm2 #4939

Revert npm3, go back to npm2 #4939

rashidkpc commented Sep 14, 2015

w33ble Sep 14, 2015

rashidkpc commented Sep 14, 2015

spalger commented Sep 17, 2015

spalger commented Sep 17, 2015

epixa commented Sep 17, 2015

spalger commented Sep 17, 2015

epixa commented Sep 17, 2015

spalger commented Sep 17, 2015

Revert npm3, go back to npm2 #4939

Revert npm3, go back to npm2 #4939

Conversation

rashidkpc commented Sep 14, 2015

w33ble Sep 14, 2015

Choose a reason for hiding this comment

rashidkpc commented Sep 14, 2015

spalger commented Sep 17, 2015

spalger commented Sep 17, 2015

epixa commented Sep 17, 2015

spalger commented Sep 17, 2015

epixa commented Sep 17, 2015

spalger commented Sep 17, 2015