Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds docs for API Keys UI #49135

Merged
merged 3 commits into from
Oct 25, 2019
Merged

[DOCS] Adds docs for API Keys UI #49135

merged 3 commits into from
Oct 25, 2019

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Oct 24, 2019

Summary

Fixes #47873

This PR adds documentation for the new API Keys UI

A formatted version of the doc is here.

[skip ci]

@gchaps gchaps added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 labels Oct 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps gchaps requested a review from KOTungseth October 24, 2019 14:52
@gchaps
Copy link
Contributor Author

gchaps commented Oct 24, 2019

@elasticmachine, run elasticsearch-ci/docs

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchaps nice job! LGTM. I left one suggestion about swapping the order of Security privileges and API key service.


[float]
[[api-keys-service]]
=== {es} API key service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to move this section above Security privileges? Even if you had the correct privileges, if the API Key service isn't enabled, you would not be able to use API keys.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea.

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR! I've made some suggestions mainly around product naming and structure.

[[api-keys]]
=== API Keys

An API key enables you to create secondary credentials with the same or lower
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API Keys or API keys?

them in *Management > Security > API Keys*.

[role="screenshot"]
image:user/security/api-keys/images/api-keys.png["API Keys UI"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the UI uses both API Keys and API keys

[[api-keys]]
=== API Keys

An API key enables you to create secondary credentials with the same or lower
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

API keys enable you to create secondary credentials so that you can send requests on behalf of other Kibana users. Secondary credentials have the same or lower access rights.


The {es} API key service is automatically enabled when you configure
{ref}/configuring-tls.html#tls-http[TLS on the HTTP interface].
This ensures that API keys are not sent in clear-text by clients.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

This makes sure that clients are unable to send API keys in clear-text.

{ref}/configuring-tls.html#tls-http[TLS on the HTTP interface].
This ensures that API keys are not sent in clear-text by clients.

If HTTPS connections are not enabled between {kib} and {es}, you will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

When HTTPS connections are not enabled between Kibana and Elasticsearch, you cannot use or manage API keys, and you get an error message.

"expiration": "1d"
}

This creates an API key with the name my_api_key that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my_api_key > my_api_key

You can also use API keys to automate ingestion of new data from
remote sources, without a live user interaction.

You can create API Keys in the {kib} Console and view and invalidate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of starting a second sentence with you can, how about:

`To create, view, and invalidate APIs keys in the Kibana Console, go to Management > Security > API Keys.

@gchaps gchaps merged commit 243a981 into elastic:master Oct 25, 2019
@gchaps gchaps deleted the api-keys branch October 25, 2019 18:59
gchaps added a commit to gchaps/kibana that referenced this pull request Oct 25, 2019
* [DOCS] Adds docs for API Keys UI

* [DOCS] Incorporates review comments into API keys doc

* [DOCS] Fixes typo
gchaps added a commit to gchaps/kibana that referenced this pull request Oct 25, 2019
* [DOCS] Adds docs for API Keys UI

* [DOCS] Incorporates review comments into API keys doc

* [DOCS] Fixes typo
gchaps added a commit that referenced this pull request Oct 25, 2019
* [DOCS] Adds docs for API Keys UI

* [DOCS] Incorporates review comments into API keys doc

* [DOCS] Fixes typo
gchaps added a commit that referenced this pull request Oct 25, 2019
* [DOCS] Adds docs for API Keys UI

* [DOCS] Incorporates review comments into API keys doc

* [DOCS] Fixes typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create user-facing docs for API Keys app
4 participants