Snapshots title ie11 misalignment #48802
Conversation
|
@elasticmachine merge upstream |
alisonelizabeth
added
Feature:Snapshot and Restore
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💚 Build Succeeded |
There was a problem hiding this comment.
@cuff-links thanks for fixing this! Change looks good.
Do you think you could apply the same fix to the policy details flyout as well?
Also, I am still seeing the issue with the button misalignment on the Repositories and Policies tabs (testing with browserstack, IE11). Do you think you could take another look?
|
@alisonelizabeth Interesting. Looking again. |
|
Can't reproduce the behavior on IE 11 on Windows 10. |
|
|
|
@cuff-links I was referring to the policy details flyout on the |
|
@alisonelizabeth The policy details flyout also has been fixed.
|
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
@cuff-links interesting. How are you testing? Here are my settings. Let me know if you want to screenshare later.
|
|
OK. Went back and looked. This was my bad. Chrome was open.... |
…inks/kibana into Snapshots_Title_IE11_Misalignment
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
@cuff-links this is looking great! I left two comments related to React warnings I noticed while testing.
Also, I noticed another layout issue in IE under the Policies tab:
I don't think this was mentioned in the original issue, so I'm happy to open up a new issue if you prefer to address separately. Let me know.
.../plugins/snapshot_restore/public/app/sections/home/policy_list/policy_table/policy_table.tsx
Show resolved
Hide resolved
...pshot_restore/public/app/sections/home/repository_list/repository_table/repository_table.tsx
Show resolved
Hide resolved
|
@alisonelizabeth Please create a new issue for the new alignment issue that you found and assign to me. :) |
💚 Build Succeeded |
@cuff-links opened #49621 |
* Removed Flexbox around header and link elements. * Removed unused EUI component * Added class to include the ellipses when name is truncated. * Fixed title in policy_details.tsx * Fixed buttons and title on policy and repository table. * Linting fixes. * Removed unused references. * Added keys to arrays of elements to resolve React errors.
* Removed Flexbox around header and link elements. * Removed unused EUI component * Added class to include the ellipses when name is truncated. * Fixed title in policy_details.tsx * Fixed buttons and title on policy and repository table. * Linting fixes. * Removed unused references. * Added keys to arrays of elements to resolve React errors.
* Removed Flexbox around header and link elements. * Removed unused EUI component * Added class to include the ellipses when name is truncated. * Fixed title in policy_details.tsx * Fixed buttons and title on policy and repository table. * Linting fixes. * Removed unused references. * Added keys to arrays of elements to resolve React errors.
* Removed Flexbox around header and link elements. * Removed unused EUI component * Added class to include the ellipses when name is truncated. * Fixed title in policy_details.tsx * Fixed buttons and title on policy and repository table. * Linting fixes. * Removed unused references. * Added keys to arrays of elements to resolve React errors.
Fixes #40109