Implement App-level lastUrl tracking #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting some strange redirect behavior |
|
Sending back for the issue above and tests that aren't passing. Code style LGTM. |
added 8 commits
September 17, 2015 15:44
We have always tracked the lastPath for tabs on the page, which means that clicking from one to the other restores your previous state. Now we are tracking the lastUrls for each app and using them in the appSwitcher so that the appSwitcher properly links to the last state of each app.
spalger
force-pushed
the
implement/appLevelLastUrl
branch
from
7f6ac1e to
9f9bbe2
Compare
spalger
force-pushed
the
implement/appLevelLastUrl
branch
2 times, most recently
from
8d4e702 to
2ecb277
Compare
spalger
force-pushed
the
implement/appLevelLastUrl
branch
2 times, most recently
from
adac24f to
7fb0d0f
Compare
|
One issue I see. When You get redirected to the status page for some error or another, you can't go to the kibana app. I suspect this is because the URL is wrong. |
|
|
|
Yeah, I think that's outside of the scope of this issue. Created #4990. |
spalger
force-pushed
the
implement/appLevelLastUrl
branch
from
12944cc to
b9c703a
Compare
|
I can't find any other problems with this. LGTM! |
Merged
panda01
added a commit
that referenced
this pull request
Sep 21, 2015
Implement App-level lastUrl tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4835
Fixes #4971
This change adds tracking of the lastUrl for each app so that every time the route changes the url is recorded to sessionStorage and can be recalled in the appSwitcher by calling
chrome.getLastUrlFor(appId).This includes tests for
TabCollection,Tab, and the chrome's "apps" api.