Range labels backport #4846
Merged
Range labels backport #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
force-pushed
the
range-labels-backport
branch
from
4af14a4 to
425cbef
Compare
|
Should probably get a LGTM from @spalger on this one too, since it was all originally his code. |
|
Looks like the data is coming back and the data table is populating correctly, but the bars are not showing up correctly. |
also fix typo in formatter cache
|
@lukasolson needed to backport #4677 too. Everything should be working now.
|
|
Hmmm, I think there's still another commit backport missing, because now I'm seeing this bug when I create a range filter on a scripted field:
|
|
Also, this fix will probably also need to be backported as part of this after the above is working: #4751 |
w33ble
force-pushed
the
range-labels-backport
branch
from
a5ac2bd to
254b382
Compare
key is an object with a toString prop, which needs to be removed - this worked in the 4.2 version by using a Symbol
|
@lukasolson good find! Scripted range filters were actually broken too - should all be fixed now.
|
|
LGTM! Passing to @spalger for a second look. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4826, which was a backport issue for #4404
This is a backport of #4613 and #4677 to the 4.1 branch