Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react references from core OverlayService apis #48429

Conversation

pgayvallet
Copy link
Contributor

Summary

Remove usages of React API/types in the core OverlayService, by changing the signature with something framework agnostic.

Pain points of the PR are:

  • some plugins were mixing KibanaReactOverlays and core.OverlayService in their usage, as they were effectively the same signature, which is no longer the case in this PR.
  • Some tests were testing the react tree renderer after calls to the overlayservice. The MountWrapper we now use to mount native HTML element in the EUI components makes this harder ( forced to use enzyme#mount, and even this does not work in some cases)

Fixes #37894

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 labels Oct 16, 2019
@pgayvallet pgayvallet requested a review from a team October 16, 2019 16:03
@pgayvallet pgayvallet requested review from a team as code owners October 16, 2019 16:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet closed this Oct 16, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new-platform] Refactor OverlayService to not require React to use
2 participants