Remove react references from core OverlayService
apis
#48429
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove usages of React API/types in the core
OverlayService
, by changing the signature with something framework agnostic.Pain points of the PR are:
KibanaReactOverlays
andcore.OverlayService
in their usage, as they were effectively the same signature, which is no longer the case in this PR.MountWrapper
we now use to mount native HTML element in the EUI components makes this harder ( forced to useenzyme#mount
, and even this does not work in some cases)Fixes #37894
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers