-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new visualize type: sankey #4832
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Can you elaborate on the enhancement here? Useful things include:
|
I use multi-layer pie chart to show functions' stack of php slowlog before, it's so great to checkout which request link is worst or changed. But, if one function name in different parent aggregations is the same, we can't merge them from other buckets in pie chart. So I think sankey chart maybe a good way to visualize. And my screenshot above show another use case: clientip -> isp -> realserver. Because I use sankey as a extension of multi-layer pie, so they could use the same dataset or testing of pie? |
@rashidkpc I add tests for sankey and now travis-ci check has passed. Anything more needed? |
name: 'metric', | ||
title: 'Slice Size', | ||
min: 1, | ||
aggFilter: ['sum', 'count', 'cardinality'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we use min/max/avg here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can. It just because the code base was copy from pie, and I used bucket.doc_count
to process resp. The newest commit change to use metric.getValue(b)
and now we can use min/max/avg
here.
What do the colors represent? This doesn't seem to be using our standard color generation system or legends? |
@rashidkpc I have change to use the standard color generation system now. |
Thanks @chenryn, this has a lot of changes in it, and there's a lot of moving parts in the visualization system right now, so it will take some time to review. I'm going to put a hold on this right now while we sort out some of the vislib API questions |
This has huge potential for access logs! |
i'm in telco business and we need this kind of graphs to analyse device traffic relationships in networks. |
+1 this would be very useful. |
加油,这个图表很有用! good job! i need sankey chart , |
Now that things are bit more stable I think it would be reasonable to implement this as a plugin. I'd rather not merge it into upstream at this time |
@rashidkpc By now all the exists visType plugin examples are using |
Hi Chenryn, [2016-11-02 11:38:06] app.INFO: referer:Login Page, uri_path:Cancel Appointment Summary page, referralNumber : 000000018010 | sessionId : nhqnlqjqn3jidtnhm9he4kbuo5 [] [] In the logs above, "referer" is "from url" and "uri_path" is the "to url" Thank you in advance. |
Hello, |
looks very good. works on 5.x ? |
+1 |
@rashidkpc what is needed to be done in order to merge this pull request? |
As @gthorsen commented in #3456 , I implement a sankey visualize type based on pie chart.