Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Use EUI to render "Local variables" for the stack trace #48208

Merged
merged 1 commit into from
Oct 16, 2019
Merged

[APM] Use EUI to render "Local variables" for the stack trace #48208

merged 1 commit into from
Oct 16, 2019

Conversation

ffknob
Copy link
Contributor

@ffknob ffknob commented Oct 15, 2019 •
edited by sorenlouv
Loading

Closes #46329

Summary

(This is the same as PR #47128, I just had to open a new one because I thought it would be a good idea to delete my Kibana fork... which it wasn't... so the original PR lost the link with the repo and I was not able to rebase to master)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@ffknob ffknob requested a review from a team as a code owner October 15, 2019 10:29
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

This was referenced Oct 15, 2019
Closed
Open
@sorenlouv
Copy link
Member

@ffknob This looks good. Thanks for the persistence. Seems like you are getting the hang of git and github :)

@sorenlouv
Copy link
Member

retest

@ffknob
Copy link
Contributor Author

ffknob commented Oct 15, 2019

@ffknob This looks good. Thanks for the persistence. Seems like you are getting the hang of git and github :)

Thank you for the patience!
I've learned a lot with this PR but I'll definetly research specifcally about the Git flow process.

I'll look for other "low hanging fruits" now!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sorenlouv
Copy link
Member

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sorenlouv sorenlouv merged commit 03a1ee1 into elastic:master Oct 16, 2019
@sorenlouv sorenlouv mentioned this pull request Oct 16, 2019
Merged
sorenlouv added a commit that referenced this pull request Oct 16, 2019
@sorenlouv
[APM] Use EUI to render "Local variables" for the stack trace (#48208) (
27ce0c6 
#48401)
@sorenlouv sorenlouv changed the title Stack trace local variables styling euitable (previous #47128) [APM] Use EUI to render "Local variables" for the stack trace Oct 16, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sorenlouv sorenlouv mentioned this pull request Oct 17, 2019
Closed
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Oct 17, 2019
@sorenlouv
[APM] Use EUI to render "Local variables" for the stack trace (elasti…
b445b0a 
…c#48208) (elastic#48401)
@sorenlouv sorenlouv mentioned this pull request Oct 17, 2019
Closed
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Oct 17, 2019
@sorenlouv
[APM] Use EUI to render "Local variables" for the stack trace (elasti…
4559361 
…c#48208) (elastic#48401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:enhancement v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Stack trace Local variables panel is not aligned with EUI vars
3 participants
@ffknob @elasticmachine @sorenlouv