Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixing overview page max anomaly score #48110

Merged
merged 2 commits into from
Oct 16, 2019
Merged

[ML] Fixing overview page max anomaly score #48110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba025f0
[ML] Fixing overview page max anomaly score
jgowdyelastic Oct 14, 2019
2c761f5
removing unnecessary copy of maxScore
jgowdyelastic Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...plugins/ml/public/overview/components/anomaly_detection_panel/anomaly_detection_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,13 @@ export const AnomalyDetectionPanel: FC = () => {
return ml.results.getMaxAnomalyScore(group.jobIds, twentyFourHoursAgo, latestTimestamp);
});

const results = await Promise.all(promises.map(p => p.catch(() => undefined)));
const results = await Promise.all(promises);
const tempGroups = { ...groupsObject };
// Check results for each group's promise index and update state
Object.keys(scores).forEach(groupId => {
const resultsIndex = scores[groupId] && scores[groupId].index;
scores[groupId] = resultsIndex !== undefined && results[resultsIndex];
tempGroups[groupId].max_anomaly_score = resultsIndex !== undefined && results[resultsIndex];
const { maxScore } = resultsIndex !== undefined && results[resultsIndex];
tempGroups[groupId].max_anomaly_score = maxScore || undefined;
});

setGroups(tempGroups);
Expand Down
2 changes: 1 addition & 1 deletion x-pack/legacy/plugins/ml/server/models/results_service/results_service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export function resultsServiceProvider(callWithRequest) {
const resp = await callWithRequest('search', query);
const maxScore = _.get(resp, ['aggregations', 'max_score', 'value'], null);

return maxScore;
return { maxScore };
}

// Obtains the latest bucket result timestamp by job ID.
Expand Down