Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare data.indexPatterns for move to NP #48083

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Prepare data.indexPatterns for move to NP #48083

merged 2 commits into from
Oct 15, 2019

Conversation

alexwizp
Copy link
Contributor

Summary

What was done in this PR:

  • Replace ui/saved_objects by core.savedObjects

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp
Prepare data.indexPatterns for move to NP
90db533 
Replace ui/saved_objects by core.savedObjects
@alexwizp alexwizp self-assigned this Oct 14, 2019
@streamich streamich mentioned this pull request Oct 14, 2019
Closed
10 tasks
@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label Oct 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:New Platform labels Oct 14, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@alexwizp
Merge remote-tracking branch 'upstream/master' into ui-saved-object
124a200 
# Conflicts:
#	src/legacy/core_plugins/data/public/index_patterns/index_patterns_service.ts
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp merged commit 2ed0ccb into elastic:master Oct 15, 2019
@alexwizp alexwizp mentioned this pull request Oct 15, 2019
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Oct 15, 2019
@alexwizp
Prepare data.indexPatterns for move to NP (elastic#48083)
ac525f8 
Replace ui/saved_objects by core.savedObjects
alexwizp added a commit that referenced this pull request Oct 15, 2019
@alexwizp
Prepare data.indexPatterns for move to NP (#48083) (#48210)
9f3f4c2 
Replace ui/saved_objects by core.savedObjects
@alexwizp alexwizp deleted the ui-saved-object branch January 4, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@lizozom lizozom Awaiting requested review from lizozom

@streamich streamich Awaiting requested review from streamich

@gospodarsky gospodarsky Awaiting requested review from gospodarsky

Assignees

@alexwizp alexwizp

Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexwizp @elasticmachine @ppisljar