[Discover] Remove error when a user without default index patterns accesses #47705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- setting uiRoutes: requireDefaultIndex to false - retrieve defaultIndex if necessary in discover route - before it was set in load_default.js
kertal
commented
Oct 9, 2019
| @@ -91,7 +91,7 @@ const app = uiModules.get('apps/discover', [ | |||
|
|
|||
| uiRoutes | |||
| .defaults(/^\/discover(\/|$)/, { | |||
| requireDefaultIndex: true, | |||
There was a problem hiding this comment.
When setting this to false, kibana no longer is trying to persist the defaultIndex when none is set
💔 Build Failed |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
…-09-discover-readonly-error
|
retest |
💔 Build Failed |
💔 Build Failed |
|
@elasticmachine merge upstream |
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
….com:kertal/kibana into kertal-pr-2019-10-09-discover-readonly-error
…-09-discover-readonly-error
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
Closed, #54122 will take over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user with only Discover read permissions (And with no write permissions to kibana* indices) and without default index pattern accessed Discover, there was a 403 error displayed, because Kibana tried to persist the id of the first entry of the index pattern list as defaultIndex.
No Discover itself takes care of finding a valid defaultIndex, without persisting it.
Fixes #46124
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately