[Code] Export integration components #47636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylnd
added
Team:Code
release_note:skip
|
Pinging @elastic/code (Team:Code) |
|
@mw-ding thoughts here? CI is currently failing due to some part of the CI/build process not liking the |
This comment has been minimized.
This comment has been minimized.
|
retest |
|
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
💔 Build Failed
|
💚 Build Succeeded
|
This separates the current CodeBlock component into two: * BareCodeBlock, which simply renders the code view without padding/margin * CodeBlock, which wraps the BareCodeBlock in an EUIPanel and allows overrides It seems like APM will want to use the former for their integration, while the latter is currently used internally by Code. It's very simple, though, and could absolutely be inlined.
This has no styling, and so a header could go right against it, it could be shown/hidden distinct from the header, etc.
Adds a 'shared' manifest that does all the reaching in; the main one just re-exports that.
This was incorrectly placed a level too high, in the plugin itself.
CodeBlockPanel = EuiPanel + CodeBlock
rylnd
force-pushed
the
export-integration-components
branch
from
04acfa2 to
53d4b03
Compare
rylnd
commented
Oct 10, 2019
| @@ -1,4 +1,4 @@ | |||
| .codeContainer__root { | |||
| .codeContainer__monaco { | |||
There was a problem hiding this comment.
@daveyholler @cchaos I renamed this because it was doing double duty: it applied both the monaco fixes here and also applied some layout rules in a layout file. .codeContainer__monaco is now solely for monaco fixes, and .codeContainer__root is for the layout stuff.
Additionally, our two uses of monaco, in our CodeBlock and EditorComponent components, both have the codeContainer__monaco class applied internally so that consumers don't need to worry about it.
💚 Build Succeeded |
daveyholler
approved these changes
Oct 10, 2019
mw-ding
approved these changes
Oct 10, 2019
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Oct 10, 2019
* Expose CodeBlockPanel component This separates the current CodeBlock component into two: * CodeBlock, which simply renders the code view without padding/margin * CodeBlockPanel which wraps the CodeBlock in an EUIPanel and allows overrides It seems like APM will want to use the former for their integration, while the latter is currently used internally by Code. It's very simple, though, and could absolutely be inlined. * Update demo page to use CodeBlock This has no styling, and so a header could go right against it, it could be shown/hidden distinct from the header, etc. * Export our current integration components from main index Adds a 'shared' manifest that does all the reaching in; the main one just re-exports that. * Move shared exports to the frontend manifest This was incorrectly placed a level too high, in the plugin itself. * Rename to better reflect relationship CodeBlockPanel = EuiPanel + CodeBlock * Distinguish monaco CSS overrides with page-specific layout
rylnd
added a commit
that referenced
this pull request
Oct 10, 2019
* Expose CodeBlockPanel component This separates the current CodeBlock component into two: * CodeBlock, which simply renders the code view without padding/margin * CodeBlockPanel which wraps the CodeBlock in an EUIPanel and allows overrides It seems like APM will want to use the former for their integration, while the latter is currently used internally by Code. It's very simple, though, and could absolutely be inlined. * Update demo page to use CodeBlock This has no styling, and so a header could go right against it, it could be shown/hidden distinct from the header, etc. * Export our current integration components from main index Adds a 'shared' manifest that does all the reaching in; the main one just re-exports that. * Move shared exports to the frontend manifest This was incorrectly placed a level too high, in the plugin itself. * Rename to better reflect relationship CodeBlockPanel = EuiPanel + CodeBlock * Distinguish monaco CSS overrides with page-specific layout
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses elastic/code#1677.
Also addresses elastic/code#1679.