Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Fix default discover url template building #47587

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

flash1293
Copy link
Contributor

This PR fixes the URL for the default discover drilldown link. It mistakenly used the index name instead of the id. This also adds a test whether templates get synced correctly with the scope.

@flash1293 flash1293 added Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Oct 8, 2019
@flash1293 flash1293 requested review from kertal and a team October 8, 2019 14:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested locally in chrome, firefox & safari. default url link's index pattern id is now correct 👍

@flash1293 flash1293 merged commit dba9da9 into elastic:master Oct 9, 2019
@flash1293 flash1293 deleted the graph/fix-templates-builder branch October 9, 2019 07:31
flash1293 added a commit to flash1293/kibana that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants