Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wording of save modal and listing page #47443

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Improve wording of save modal and listing page #47443

merged 2 commits into from
Oct 10, 2019

Conversation

flash1293
Copy link
Contributor

This PR changes some wordings in the generic component for listing pages and save modals (used in visualize, dashboard, maps, graph, discover):

Changed: Save as new (remove “a”)
Screenshot 2019-10-07 at 11 33 30

Changed: Title: Remove period in title “A with …”
Description: Clicking Save overwrites the existing .
Button: Save
Screenshot 2019-10-07 at 11 33 34

Changed: Button: Create (without new)
Screenshot 2019-10-07 at 11 33 38

Changed: Delete 1 ? (removed selected)
Screenshot 2019-10-07 at 11 33 42

Changed: Delete 2 ? (removed selected)
Screenshot 2019-10-07 at 11 33 45

Small change along the same lines: Aria label of "Save as new" button in saved query management changed from Save as a new saved query to Save as new saved query

@flash1293 flash1293 requested a review from gchaps October 7, 2019 09:41
@flash1293 flash1293 requested a review from a team as a code owner October 7, 2019 09:41
@flash1293 flash1293 added Feature:kibana-react Team:AppArch Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v8.0.0 labels Oct 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@flash1293 flash1293 added the release_note:skip Skip the PR/issue when compiling release notes label Oct 7, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

gchaps
gchaps approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lizozom
lizozom approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@flash1293 flash1293 merged commit c2dff77 into elastic:master Oct 10, 2019
@flash1293 flash1293 deleted the flash1293/improve-save-modal-wording branch October 10, 2019 12:04
@flash1293 flash1293 mentioned this pull request Oct 10, 2019
Merged
flash1293 added a commit to flash1293/kibana that referenced this pull request Oct 10, 2019
@flash1293
improve wording of save modal and listing page (elastic#47443)
73826dd
flash1293 added a commit that referenced this pull request Oct 10, 2019
@flash1293
improve wording of save modal and listing page (#47443) (#47823)
06764ed
This was referenced Mar 23, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@lizozom lizozom lizozom approved these changes

Assignees
No one assigned
Labels
Feature:kibana-react release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flash1293 @elasticmachine @lizozom @gchaps