Fix issues with elasticsearch and ssl #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
changed the title
|
Checked out the latest, and... it works for me! |
|
Works for me as well, and the changes all make sense. LGTM, passing on for final code review. |
| module.exports = function (server) { | ||
| var https = require('https'); | ||
|
|
||
| module.exports = _.memoize(function (server) { |
There was a problem hiding this comment.
Memoize doesn't work with objects, does it? Pretty sure it stringifies these. You'll probably need to set module.exports.cache to be a new Map() or something for this to work right.
There was a problem hiding this comment.
Or just cache them in a Map yourself
There was a problem hiding this comment.
You're totally right. I'll fix this. Good catch.
|
LGTM! |
spalger
added a commit
that referenced
this pull request
Aug 26, 2015
Fix issues with elasticsearch and ssl
This was referenced May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4697.
There were several issues when we ported the agent creation from the old server architecture to the new one.
https.Agent, but instead usedhttp.Agenteven if https was specified in the config.agentOptions, which seems harmless, but for some unknown reason, if you use the same options object when callingnew https.Agent(options), the agent you get on calls after the first has problems withPOSTrequests (but notPUT... bizarre, I know). I've changed the function to use_.memoizeinstead of manually cachingagentOptions, and doing so caches the entireAgentobject instead of just theagentOptions.crtas an option instead ofcert(as the API instructs).