Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Convert uiSettings service to TypeScript (#47018) #47320

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Oct 4, 2019

Backports the following commits to 7.x:

* tsify is_config_version_upgradeable

* tsify get_upgradeable_config

* tsify create_or_upgrade_saved_config

* tsify ui_settings_service

* tsify ui_settings_service_factory

* tsify ui_settings_service_for_request

* declare types on server object

* tsify set route

* tsify set_many route

* tsify get route

* tsify delete route

* tsify logWithMetadata

* improve ui_settings_service typings

* introduce uiService mocks

* remove private methods from public contract

* add types for server.uiSettingsServiceFactory

* rename IUiSettingsService --> IUiSettingsClient
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mshustov mshustov merged commit 609a6c1 into elastic:7.x Oct 4, 2019
@mshustov mshustov deleted the backport/7.x/pr-47018 branch October 4, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants