SavedObjectAttribute allow array of primitives #47317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
rudolf
force-pushed
the
saved-object-attribute-type
branch
from
ce9cf7f to
f4245e0
Compare
💚 Build Succeeded |
3 tasks
eliperelman
approved these changes
Oct 7, 2019
| @@ -43,26 +43,33 @@ export interface SavedObjectsMigrationVersion { | |||
| } | |||
|
|
|||
| /** | |||
| * Don't use this type, it's simply a helper type for {@link SavedObjectAttribute} | |||
There was a problem hiding this comment.
Is it possible to remove the @public annotation to assist with this?
There was a problem hiding this comment.
Yeah that was my first attempt, but then it also gets excluded from our generated docs and in effect a user reading the docs is left with just export type SavedObjectAttribute = SavedObjectAttributeSingle | SavedObjectAttributeSingle[]; which isn't very useful :(
💚 Build Succeeded |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Oct 8, 2019
rudolf
added a commit
that referenced
this pull request
Oct 8, 2019
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the
SavedObjectAttributetype to be more useful for other API's which accept method paramaters of the form(key: string, value: SavedObjectAttribute)see #47018 (comment)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers