-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Moves URL, interval and ordinal ui utils into ML #47221
[ML] Moves URL, interval and ordinal ui utils into ML #47221
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
💚 Build Succeeded |
* [ML] Moves URL, interval and ordinal ui utils into ML * [ML] Edits to url_utils following review
Summary
As part of the migration to the new platform, copies several utility functions which were previously from the legacy
ui
folder into the ML codebase:ui/url/relative_to_absolute
(copied as-is into new MLutil/url_utils
)ui/utils/ordinal_suffix
(added new MLformatters/number_as_ordinal
which uses the numeral.js ordinal formatui/utils/parse_interval
(switched all ML code to use the existing MLcommon/util/parse_interval
Also removed unused
ui/kbn_top_nav
import fromapp.js
.Note that the ML
common/util/parse_interval
differs from the legacyui/utils/parse_interval
in the following ways:Checklist