[Uptime] Add Donut chart #47176
Merged
[Uptime] Add Donut chart #47176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
release_note:enhancement
v8.0.0
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
💔 Build Failed
|
shahzad31
reviewed
Oct 3, 2019
x-pack/legacy/plugins/uptime/public/components/functional/donut_chart.tsx
Outdated
Show resolved
Hide resolved
justinkambic
force-pushed
the
uptime_donut-chart
branch
from
53884b8 to
191a2f5
Compare
💔 Build Failed
|
💔 Build Failed
|
justinkambic
force-pushed
the
uptime_donut-chart
branch
from
bd035eb to
9530a68
Compare
💔 Build Failed
|
💔 Build Failed
|
justinkambic
force-pushed
the
uptime_donut-chart
branch
from
7da1b29 to
2f468a3
Compare
💔 Build Failed
|
💔 Build Failed
|
💔 Build Failed
|
|
@elasticmachine merge upstream |
💔 Build Failed
|
justinkambic
force-pushed
the
uptime_donut-chart
branch
from
f940f4b to
55be6d8
Compare
💚 Build Succeeded
|
|
I'm getting a blank screen and this error in the JS debugger (on firefox)
|
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 14, 2019
* Add donut chart. * Merge donut chart with snapshot histogram panel. * Update broken test snapshot. * Undo removal of gray color from histogram chart. * Use proper color values for donut chart and legend. * Move donut chart to charts directory. * Add snapshot tests for new chart components. * Merge donut chart with snapshot histogram panel. * Revert d3 version. * Revert yarn.lock. * Revert code to be compatible with older d3 version. * Delete duplicated files. * Clean up code. * Improve const names. * Update outdated snapshots. * Fix broken type. * Simplify function, add comment. * Remove unused translations. * Fix broken chart component. * Implement designer feedback. * Fix regression. * Implement additional designer feedback. * Fix issue that caused residual paths to remain on subsequent paints of donut chart. * Update obsolete test snapshots. * Revert yarn.lock. * Rename repurposed translation. * Delete obsolete translations. * Update busted test snapshot.
justinkambic
added a commit
that referenced
this pull request
Oct 15, 2019
* Add donut chart. * Merge donut chart with snapshot histogram panel. * Update broken test snapshot. * Undo removal of gray color from histogram chart. * Use proper color values for donut chart and legend. * Move donut chart to charts directory. * Add snapshot tests for new chart components. * Merge donut chart with snapshot histogram panel. * Revert d3 version. * Revert yarn.lock. * Revert code to be compatible with older d3 version. * Delete duplicated files. * Clean up code. * Improve const names. * Update outdated snapshots. * Fix broken type. * Simplify function, add comment. * Remove unused translations. * Fix broken chart component. * Implement designer feedback. * Fix regression. * Implement additional designer feedback. * Fix issue that caused residual paths to remain on subsequent paints of donut chart. * Update obsolete test snapshots. * Revert yarn.lock. * Rename repurposed translation. * Delete obsolete translations. * Update busted test snapshot.
This was referenced Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #44533.
Adds a donut chart to replace the existing snapshot count visualization.
Merges the snapshot count panel with the histogram at the top of the overview page.
Testing this PR