[Graph] Fix functional tests #47053

flash1293 · 2019-10-01T16:13:56Z

Re-enables Graph functional tests with retries in places where route changes happen (because they are not reliable in all scenarios).

Also accounts for UI changes done in the meantime.

elasticmachine · 2019-10-01T16:13:58Z

Pinging @elastic/kibana-app

flash1293 · 2019-10-01T16:14:55Z

x-pack/test/functional/apps/graph/graph.ts

@@ -47,67 +46,57 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
      '/blog/wp-admin/',
    ];

-    const expectedConnectionWidth: Record<string, Record<string, number>> = {
-      '/blog/wp-admin/': { wp: 2, blog: 5.51581 },
+    const expectedConnections: Record<string, Record<string, boolean>> = {


After syncing with @markharwood it doesn't make sense to validate specific line lengths because the exact numbers can change because of a lot of things.

flash1293 · 2019-10-01T16:15:18Z

x-pack/test/functional/apps/graph/graph.ts

@@ -122,11 +111,15 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
      const { nodes } = await PageObjects.graph.getGraphObjects();
      const circlesText = nodes.map(({ label }) => label);
      expect(circlesText.length).to.equal(expectedNodes.length);
-      expect(circlesText).to.eql(expectedNodes);
+      circlesText.forEach(circleText => {


Don't validate the order of nodes because it doesn't matter

elasticmachine · 2019-10-01T17:21:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

flash1293 · 2019-10-02T07:13:43Z

Jenkins, test this

elasticmachine · 2019-10-02T08:39:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…tional-tests

elasticmachine · 2019-10-02T13:50:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-10-02T15:11:43Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…tional-tests

elasticmachine · 2019-10-03T09:30:27Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: be3646b

kertal

Code LGTM, tested locally, no fails, however, it didn't fail in my environment before

…tional-tests

elasticmachine · 2019-10-04T09:24:35Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 348e1b9

…tional-tests

elasticmachine · 2019-10-04T11:14:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6a3df14

x-pack/test/functional/page_objects/graph_page.ts

flash1293 · 2019-10-04T15:00:13Z

Jenkins, test this

elasticmachine · 2019-10-04T16:16:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f130165

flash1293 · 2019-10-07T07:20:34Z

@elasticmachine merge upstream

elasticmachine · 2019-10-07T08:24:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ab027a6

flash1293 · 2019-10-07T09:03:03Z

Jenkins, test this. Flaky unrelated test

elasticmachine · 2019-10-07T10:07:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ab027a6

dmlemeshko · 2019-10-08T08:57:01Z

Hey @flash1293
I ran your test locally and it works fine. However, when I run it on CI 20x times in parallel I can see this failure:

 1) graph app
       graph
         should show correct node labels:
     Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="graph-field-search"])
Wait timed out after 10027ms

If it is a timing issue, maybe you replace sleep with smth like

testSubjects.existOrFail('graph-field-search', { timeout: 20000 });

test PR #47555

Upd: looks like await PageObjects.graph.selectIndexPattern('secrepo*'); is not always working

LeeDr

LGTM - If we find flakiness in this test going forward we need to do 2 things;

make sure we have API tests for Graph (maybe with the same data set) and see if we get the exact same response from the API every time
trim the test down until it's reliable. It's better to have some functional test of graph than none.

…tional-tests

…kibana into graph/enable-functional-tests

…tional-tests

flash1293 · 2019-10-09T08:06:10Z

@dmlemeshko I tested my stabilization with 20 runs here #47592 , no failures

EDIT: Merged in your test commit on accident, reverting and re-running.

elasticmachine · 2019-10-09T09:12:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: cae13ee

This reverts commit 4bfaa4f.

elasticmachine · 2019-10-09T10:41:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fbada9c

dmlemeshko

LGTM. I didn't test it locally, but 20 successful runs on CI is a good sign.

re-enable graph tests

df1ea74

flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Oct 1, 2019

flash1293 commented Oct 1, 2019

View reviewed changes

flash1293 added the Feature:Graph Graph application feature label Oct 2, 2019

flash1293 marked this pull request as ready for review October 2, 2019 07:13

flash1293 requested a review from a team October 2, 2019 07:13

flash1293 requested review from kertal and LeeDr October 2, 2019 09:09

flash1293 added 2 commits October 2, 2019 14:44

stabilize new graph navigation

391959a

Merge remote-tracking branch 'upstream/master' into graph/enable-func…

d48ea4b

…tional-tests

fix functional tests for new html structure

9a9cacd

flash1293 added 2 commits October 3, 2019 09:45

Merge remote-tracking branch 'upstream/master' into graph/enable-func…

ddc5fbf

…tional-tests

fix style parser

be3646b

kertal approved these changes Oct 3, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into graph/enable-func…

348e1b9

…tional-tests

flash1293 added 2 commits October 4, 2019 11:36

Merge remote-tracking branch 'upstream/master' into graph/enable-func…

3473fc8

…tional-tests

fix functional tests due to UI changes

6a3df14

dmlemeshko reviewed Oct 4, 2019

View reviewed changes

x-pack/test/functional/page_objects/graph_page.ts Outdated Show resolved Hide resolved

wait for guidance panel instead of sleeping

f130165

elastic deleted a comment from elasticmachine Oct 4, 2019

Merge branch 'master' into graph/enable-functional-tests

ab027a6

LeeDr approved these changes Oct 8, 2019

View reviewed changes

flash1293 and others added 5 commits October 8, 2019 16:19

Merge remote-tracking branch 'upstream/master' into graph/enable-func…

a2aa243

…tional-tests

run x-pack-ciGroup1 20x times

4bfaa4f

Merge branch 'graph/enable-functional-tests' of github.com:flash1293/…

89e5950

…kibana into graph/enable-functional-tests

Merge remote-tracking branch 'upstream/master' into graph/enable-func…

9bb0c3d

…tional-tests

wait for dom changes instead of sleeping

cae13ee

flash1293 mentioned this pull request Oct 9, 2019

Graph/enable functional tests scratchpad #47592

Closed

Revert "run x-pack-ciGroup1 20x times"

fbada9c

This reverts commit 4bfaa4f.

dmlemeshko approved these changes Oct 9, 2019

View reviewed changes

flash1293 merged commit fcc4c48 into elastic:master Oct 9, 2019

flash1293 deleted the graph/enable-functional-tests branch October 9, 2019 14:13

flash1293 mentioned this pull request Oct 9, 2019

[7.x] [Graph] Fix functional tests (#47053) #47704

Merged

flash1293 added a commit to flash1293/kibana that referenced this pull request Oct 9, 2019

[Graph] Fix functional tests (elastic#47053)

8dcb58b

flash1293 added a commit that referenced this pull request Oct 9, 2019

[Graph] Fix functional tests (#47053) (#47704)

421110f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Graph] Fix functional tests #47053

[Graph] Fix functional tests #47053

flash1293 commented Oct 1, 2019

elasticmachine commented Oct 1, 2019

flash1293 Oct 1, 2019

flash1293 Oct 1, 2019

elasticmachine commented Oct 1, 2019

flash1293 commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

elasticmachine commented Oct 3, 2019

kertal left a comment

elasticmachine commented Oct 4, 2019

elasticmachine commented Oct 4, 2019

flash1293 commented Oct 4, 2019

elasticmachine commented Oct 4, 2019

flash1293 commented Oct 7, 2019

elasticmachine commented Oct 7, 2019

flash1293 commented Oct 7, 2019

elasticmachine commented Oct 7, 2019

dmlemeshko commented Oct 8, 2019 •

edited

Loading

LeeDr left a comment

flash1293 commented Oct 9, 2019 •

edited

Loading

elasticmachine commented Oct 9, 2019

elasticmachine commented Oct 9, 2019

dmlemeshko left a comment

[Graph] Fix functional tests #47053

[Graph] Fix functional tests #47053

Conversation

flash1293 commented Oct 1, 2019

elasticmachine commented Oct 1, 2019

flash1293 Oct 1, 2019

Choose a reason for hiding this comment

flash1293 Oct 1, 2019

Choose a reason for hiding this comment

elasticmachine commented Oct 1, 2019

💚 Build Succeeded

flash1293 commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

💚 Build Succeeded

elasticmachine commented Oct 2, 2019

💔 Build Failed

elasticmachine commented Oct 2, 2019

💔 Build Failed

elasticmachine commented Oct 3, 2019

💚 Build Succeeded

kertal left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 4, 2019

💔 Build Failed

elasticmachine commented Oct 4, 2019

💚 Build Succeeded

flash1293 commented Oct 4, 2019

elasticmachine commented Oct 4, 2019

💚 Build Succeeded

flash1293 commented Oct 7, 2019

elasticmachine commented Oct 7, 2019

💔 Build Failed

flash1293 commented Oct 7, 2019

elasticmachine commented Oct 7, 2019

💚 Build Succeeded

dmlemeshko commented Oct 8, 2019 • edited Loading

LeeDr left a comment

Choose a reason for hiding this comment

flash1293 commented Oct 9, 2019 • edited Loading

elasticmachine commented Oct 9, 2019

💔 Build Failed

elasticmachine commented Oct 9, 2019

💚 Build Succeeded

dmlemeshko left a comment

Choose a reason for hiding this comment

dmlemeshko commented Oct 8, 2019 •

edited

Loading

flash1293 commented Oct 9, 2019 •

edited

Loading