-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WMS map server support #4701
Conversation
6e541f3
to
b20d83a
Compare
Tried this out, a couple of questions and comments:
|
Hey @rashidkpc, how about being able to configure a TMS server (the more popular kind of mapping server), like I did in #2605? Also I think it should be possible to set the default mapping server in advanced settings, having to tell your users what settings to put in every time they do a new map visualization would be tiresome, if for whatever reason they can't or don't want to use the supplied default. I'm happy to fixup #2605 if that would help, although neither PR's have tests. |
Would also be good to make defaults for these settings configurable. |
Updated with ability to configure default params as well as ability to turn on wms setting by default. |
WMS supports the idea of layers, so it sounds like the map server that you were hitting may have had a blank layer @tbragin. It's a pretty big nuisance. I wonder if we should a basic low resolution tile (or four) to represent the globe as the true bottom layer? |
Looks good. One small thing I noticed is that it's possible to do the following workflow:
I wonder if we should gray out the Apply button, unless Geo Coordinates are set in the first screen? This is the current behavior in options, unless you enable WMS server options. |
Similar to the comment above, if you visualize a geo field from Discover, then go to options and enable WMS, you can't click the go button. |
'visualization:tileMap:WMSdefaults': { | ||
value: JSON.stringify({ | ||
enabled: false, | ||
url: 'http://basemap.nationalmap.gov/arcgis/services/USGSTopo/MapServer/WMSServer', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth using // or https by default
One comment above, otherwise code LGTM. I was able to reproduce not clicking on go when coming from the discover page. |
Indeed this doesn't work when coming from discover, it seems to be caused by the fact that |
Closes #1902
Adds WMS map server on a per-map basis. It has a few defaults filled in that I know work, but there aren't exactly many public WMS server out there. I tried approximately 30 of the ones listed in #1902 (comment), they were all down. The only ones I found that had world maps were from the USGS: http://viewer.nationalmap.gov/example/services/serviceList.html
I labelled this as being for advanced users only since getting everything right is important and you generally need to read an XML document to understand what the server supports.