-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing date patch #4694
missing date patch #4694
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Looks good @scampi! Two small concerns before merging:
|
thanks for the review @jbudz. Both points should be ok now. |
jenkins, test it |
Thanks @scampi! One other issue, the test won't run unless it's loaded in https://github.com/elastic/kibana/blob/master/src/ui/public/stringify/__tests__/index.js |
oops... added |
jenkins, test it |
LGTM |
thanks @jbudz |
closes #4693