[Uptime]Update monitor list table description by adding aria-label for accessibility #46696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
v7.5.0
v8.0.0
release_note:fix
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime |
💔 Build Failed |
x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Justin Kambic <[email protected]>
💚 Build Succeeded |
|
This is looking good now but I think you need to update your test snapshot. |
💔 Build Failed |
💚 Build Succeeded |
shahzad31
deleted the
fix/issue-36035--monitor-status-table-description-for-accessibility
branch
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Sep 30, 2019
…r accessibility (elastic#46696) * update table description * update snaps * In description update data length Co-Authored-By: Justin Kambic <[email protected]> * update description * update snaps
shahzad31
added a commit
that referenced
this pull request
Sep 30, 2019
…r accessibility (#46696) (#46905) * update table description * update snaps * In description update data length Co-Authored-By: Justin Kambic <[email protected]> * update description * update snaps
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #36035
Updated monitor list table description by adding aria-label for accessibility
Checklist
This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
For maintainers
##Testing:
Move to monitor list table by using screen reader and it will read proper description now like
'Monitor Status table with 5 rows of data and columns for Status, Name, URL, IP, Downtime History and Integrations'