i18n - allow plugins to specify multiple paths #46578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
legrego
added
Feature:NP Migration
Project:i18n
release_note:skip
💚 Build Succeeded |
|
Gonna pull the code and test it locally, changes LGTM looking at the PR |
💚 Build Succeeded |
spalger
reviewed
Sep 25, 2019
spalger
reviewed
Sep 25, 2019
💚 Build Succeeded |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Sep 26, 2019
* allow plugins to specify multiple paths * use native Array.flat instead of _.flatten()
legrego
added a commit
that referenced
this pull request
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, plugins can only specify a single path in the
.i18nrc.jsonfile. This PR allows for multiple paths to be specified per plugin (i.e., per prefix), which facilitates migrating plugins to the new platform (see #46181). This way, plugins can be defined in both the legacy and new platforms during a migration, without having to specify a new prefix just for the migration period.This code was extracted from #46181, so a working example can be found there.