[ML] Combines ui/time_buckets into MlTimeBuckets #46227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
chore
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
walterra
reviewed
Sep 24, 2019
|
@walterra there wasn't any test coverage for the original time_buckets.js code, and we already have good coverage for |
peteharverson
force-pushed
the
ml-time-buckets
branch
from
cc0e0d1 to
8fe3dec
Compare
jgowdyelastic
approved these changes
Sep 24, 2019
💚 Build Succeeded |
peteharverson
force-pushed
the
ml-time-buckets
branch
from
8749e8a to
3999afb
Compare
|
Still LGTM |
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Sep 25, 2019
* [ML] Combines ui/time_buckets into MlTimeBuckets * [ML] Add unit tests for ml calc_auto_interval * [ML] Rename MlTimeBuckets to TimeBuckets
peteharverson
added a commit
that referenced
this pull request
Sep 25, 2019
78 tasks
2 tasks
walterra
added a commit
that referenced
this pull request
Mar 20, 2024
#178756) ## Summary Follow up to #46227. Consolidates multiple copies of `time_buckets.js` into `@kbn/ml-time-buckets`. The scope of this PR is just to consolidate the files. In follow ups we still need to: Refactor JS to TS and get rid of the code that uses this using "dependency cache" in the `ml` plugin. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ML was making heavy use of the Kibana
TimeBucketsobject (ui/time_buckets), in calculating the aggregation interval for time series charts. This was both through direct use, and with theMlTimeBucketsobject which inherited fromTimeBucketsbut with added functionality for setting the number of bars to target in the chart.As discussed in #44249, in preparation for the new platform Kibana
TimeBucketswill become part of the data plugin, and won't be exposed as an API. This PR therefore copies intoml_time_buckets.jsthe parts ofTimeBucketsfromui/time_bucketswhich were being inherited, and switches all usage in the ML plugin toMlTimeBuckets.The code has been copied in unchanged, apart from dropping the cache object which was used in the Kibana TimeBuckets.
Checklist
Fixes #44249