-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply all validation rules to empty strings #46167
Merged
joshdover
merged 1 commit into
elastic:master
from
joshdover:config-schema/fix-empty-strings
Sep 25, 2019
Merged
Apply all validation rules to empty strings #46167
joshdover
merged 1 commit into
elastic:master
from
joshdover:config-schema/fix-empty-strings
Sep 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Feature:New Platform
labels
Sep 19, 2019
Pinging @elastic/kibana-platform |
joshdover
commented
Sep 19, 2019
💔 Build Failed |
joshdover
force-pushed
the
config-schema/fix-empty-strings
branch
from
September 19, 2019 19:05
ae3a67c
to
3434adf
Compare
joshdover
added
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
v7.5.0
release_note:skip
Skip the PR/issue when compiling release notes
and removed
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
labels
Sep 19, 2019
joshdover
force-pushed
the
config-schema/fix-empty-strings
branch
2 times, most recently
from
September 19, 2019 19:42
db2c50f
to
1e05d80
Compare
💚 Build Succeeded |
💚 Build Succeeded |
joshdover
force-pushed
the
config-schema/fix-empty-strings
branch
from
September 23, 2019 15:08
1e05d80
to
23e2b3a
Compare
mshustov
approved these changes
Sep 23, 2019
7 tasks
💚 Build Succeeded |
joshdover
force-pushed
the
config-schema/fix-empty-strings
branch
from
September 24, 2019 22:35
23e2b3a
to
1728642
Compare
💚 Build Succeeded |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Sep 25, 2019
joshdover
added a commit
that referenced
this pull request
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:New Platform
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug with the
@kbn/config-schema
package where empty strings would skip any other validations defined in the schema.For example, these examples would not throw a validation error prior to this change:
cc @legrego
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers