[Code] frontend telemetry #46154
Merged
[Code] frontend telemetry #46154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangQianliang
added
v8.0.0
Team:Code
release_note:skip
|
Pinging @elastic/code |
|
This is a follow up PR of #45467 |
mw-ding
reviewed
Sep 19, 2019
| @@ -129,6 +130,7 @@ export class CodeFileTree extends React.Component<Props, State> { | |||
| const path = flattenFrom ? flattenFrom.path! : node.path!; | |||
| this.toggleTree(path); | |||
| this.onClick(node); | |||
| trackCodeUiMetric(METRIC_TYPE.COUNT, 'fileTree'); | |||
There was a problem hiding this comment.
can we add the metrics name/enum to this place: https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/code/model/usage_telemetry_metrics.ts#L7, instead of hardwiring them in code?
There was a problem hiding this comment.
And it would be great if you can elaborate on what does each metric mean there as comments.
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
mw-ding
approved these changes
Sep 23, 2019
| @@ -8,4 +8,12 @@ export enum CodeUsageMetrics { | |||
| ENABLED = 'enabled', | |||
| REPOSITORIES = 'repositories', | |||
| LANGUAGE_SERVERS = 'langserver', | |||
| ADMIN_PAGE_LOAD_COUNT = 'adminPageLoadCount', | |||
There was a problem hiding this comment.
one last comment before merging this PR. Let's separate the metrics for backend and frontend. Moves these new ones to sth like CodeUsageUiMetrics?
💚 Build Succeeded |
|
@Bamieh friendly ping on the review. |
Bamieh
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
click counts on
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately