Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas][i18n] Sidebar #46090

Merged
merged 6 commits into from
Oct 5, 2019
Merged

[Canvas][i18n] Sidebar #46090

merged 6 commits into from
Oct 5, 2019

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Sep 18, 2019 •
edited
Loading

Summary

Related to #23222.

This adds i18n support to the Sidebar component and all nested components.

Default view (no elements selected)

Screen Shot 2019-09-17 at 5 13 26 PM

One non-group element selected

Screen Shot 2019-09-17 at 10 52 23 PM

Multiple elements selected

Screen Shot 2019-09-17 at 10 52 42 PM

One grouped element selected

Screen Shot 2019-09-17 at 10 52 49 PM

Sidebar header context menu

Screen Shot 2019-09-17 at 10 52 30 PM

Save custom element modal

Screen Shot 2019-09-23 at 10 37 56 PM

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cqliu1
This is a combination of 5 commits.
1511eb8 
Extracts i18n strings from sidebar_content

Extracts i18n strings from element_settings

Extracted i18n strings from workpad_config

Extracts i18n strings from page_config

Extracts i18n strings from group_settings

Extracts i18n strings from element_config and multi_element_settings

Extracted remaining strings from element_config

Extracts i18n strings from sidebar_header

Extracts i18n strings from custom_element_modal

Fixed file picker placeholder

Fixed i18n ids
@cqliu1 cqliu1 added Project:i18n review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.5.0 v8.0.0 labels Sep 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@cqliu1 cqliu1 added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes labels Sep 24, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@crob611
Copy link
Contributor

crob611 commented Sep 24, 2019

image

This translation being long makes it overflow the box. Probably should make an issue separate from this PR to see if we can stop that from happening since we're not sure how long translations will be.

crob611
crob611 approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

x-pack/legacy/plugins/canvas/i18n/components.ts
PageConfig: {
getBackgroundColorDescription: () =>
i18n.translate('xpack.canvas.pageConfig.backgroundColorDescription', {
defaultMessage: 'Accepts HEX, RGB or HTML color names',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Hex RGB and HTML be constants?

Copy link
Contributor Author

@cqliu1 cqliu1 Oct 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. I looked them up in wikipedia in multiple languages, and in some languages they are translated to something else. I'll leave that to the translators to decide how to handle those.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cqliu1 cqliu1 marked this pull request as ready for review October 4, 2019 19:40
@cqliu1 cqliu1 requested a review from a team as a code owner October 4, 2019 19:40
crob611
crob611 approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good 👍

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cqliu1 cqliu1 merged commit aa1102d into elastic:master Oct 5, 2019
@cqliu1 cqliu1 deleted the i18n/sidebar branch October 5, 2019 01:21
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 7, 2019
@jloleysens
Merge branch 'console-token-iterator' of github.com:jloleysens/kibana…
1c7dcbd 
… into console-token-iterator

* 'console-token-iterator' of github.com:jloleysens/kibana: (184 commits)
  [functional/services] update webdriver lib and types (elastic#47381)
  Standardizing IconField implementation across the app (elastic#47196)
  Move ui/value_suggestions ⇒ NP data plugin (elastic#45762)
  Remove ui/persisted_log - Part 2 (elastic#47236)
  Update gulp related packages (elastic#47421)
  Update dependency idx to ^2.5.6 (elastic#47399)
  try running fewer jobs in parallel on the same worker (elastic#47403)
  Update webpack related packages (elastic#47402)
  Update jsonwebtoken related packages (elastic#47400)
  Update gulp related packages (major) (elastic#46665)
  Update dependency prettier to ^1.18.2 (elastic#47340)
  Update dependency @types/puppeteer to ^1.20.1 (elastic#47339)
  Update dependency @elastic/elasticsearch to ^7.4.0 (elastic#47338)
  Update dependency tar-fs to ^1.16.3 (elastic#47341)
  [Code] Code Integrator Component (elastic#47180)
  [Canvas][i18n] Sidebar (elastic#46090)
  Generate uuid in task Manager as Kibana uuid may not yet have been initialised
  [Code] Embedded Code Snippet Component (elastic#47183)
  Revert "Add pipeline for flaky test runner job (elastic#46740)"
  SearchSource: fix docvalue_fields and fields intersection logic (elastic#46724)
  ...
@cqliu1 cqliu1 mentioned this pull request Oct 7, 2019
Merged
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Oct 7, 2019
@cqliu1
[Canvas][i18n] Sidebar (elastic#46090)
b18f531 
    *  This is a combination of 5 commits.

    Extracts i18n strings from sidebar_content

    Extracts i18n strings from element_settings

    Extracted i18n strings from workpad_config

    Extracts i18n strings from page_config

    Extracts i18n strings from group_settings

    Extracts i18n strings from element_config and multi_element_settings

    Extracted remaining strings from element_config

    Extracts i18n strings from sidebar_header

    Extracts i18n strings from custom_element_modal

    Fixed file picker placeholder

    Fixed i18n ids

    * Alphabetize keys

    * Fixed save button label

    * fixed merge conflict
cqliu1 added a commit that referenced this pull request Oct 7, 2019
@cqliu1
[7.x] [Canvas][i18n] Sidebar (#46090) (#47512)
5ee5a82 
*  This is a combination of 5 commits.

    Extracts i18n strings from sidebar_content

    Extracts i18n strings from element_settings

    Extracted i18n strings from workpad_config

    Extracts i18n strings from page_config

    Extracts i18n strings from group_settings

    Extracts i18n strings from element_config and multi_element_settings

    Extracted remaining strings from element_config

    Extracts i18n strings from sidebar_header

    Extracts i18n strings from custom_element_modal

    Fixed file picker placeholder

    Fixed i18n ids

    * Alphabetize keys

    * Fixed save button label

    * fixed merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:i18n release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cqliu1 @elasticmachine @crob611