-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] Add I/O metrics for Elasticsearch #45870
Conversation
@elasticmachine merge upstream |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Looks good 👍 Approved, so long as all the checks pass
I don't recall any precedence for this, but is it better for users if we do not bother displaying this chart if the node is running on an unsupported platform (more specifically, if the ES data does not exist)? |
@chrisronline Ultimately, yes, that would be better. I went this route for two reasons.
|
Sounds good. I do think that showing a chart that we know will be empty is not a great UX, but we don't have to address it right now. Also, there are missing labels on this PR |
@chrisronline Just so there's no confusion -- I agree with this. In thinking this through, I think there are a few ways in which we'll want to filter/display the metrics that are shown in the long run. For example, I think we'll soon encounter a need to show different metrics based on the role a node has in a cluster. So, I think it's best dealt with in a change that ensures that we account for all of that. I'll create a new issue shortly that expands on my thinking in that regard. |
1c49f9d
to
bad5bbe
Compare
💔 Build Failed |
💚 Build Succeeded |
* I/O metrics POC * Gather correct metric for total * Remove io stats from advanced * Move io stats to node overview page * Add new io metrics * Add new io metrics * Add note about supported platforms * Update snapshot * Add warning about platforms to all metrics * Another snapshot update * Update type and units * Remove errant trailing comma * Snapshot update for new types * Add node_io integration testing
Summary
Add I/O metrics for Elasticsearch to Stack Monitoring. This metric tracks I/O operations/sec for the system on which Elasticsearch is running.
The following metric is now displayed on node overview pages:
On certain platforms, such as OS X, Elasticsearch does not collect I/O metrics. To account for this, a warning is displayed in the tool tip:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers