Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/tsvb functional tests #45868

Merged
merged 12 commits into from
Sep 18, 2019
Merged

Fix/tsvb functional tests #45868

merged 12 commits into from
Sep 18, 2019

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Sep 17, 2019 •
edited
Loading

Summary

Fix flaky tests. Closes #45323, closes #45330, closes #45744

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 17, 2019 •
edited by dmlemeshko
Loading

💚 Build Succeeded

12x Chrome + 8x FF

@dmlemeshko
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 17, 2019 •
edited by dmlemeshko
Loading

💚 Build Succeeded

12x Chrome + 8x FF

@dmlemeshko
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 17, 2019 •
edited by dmlemeshko
Loading

💚 Build Succeeded

12x Chrome + 8x FF

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2019 •
edited by dmlemeshko
Loading

💔 Build Failed

Unrelated API test failure:

X-Pack API Integration Tests.x-pack/test/api_integration/apis/telemetry/telemetry_local·js.apis Telemetry /api/telemetry/v2/clusters/_stats with monitoring disabled should pull local stats and validate data types

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2019 •
edited by dmlemeshko
Loading

💔 Build Failed

The same API failed test:

X-Pack API Integration Tests.x-pack/test/api_integration/apis/telemetry/telemetry_local·js.apis Telemetry /api/telemetry/v2/clusters/_stats with monitoring disabled should pull local stats and validate data types

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

dmlemeshko
dmlemeshko commented Sep 18, 2019
View reviewed changes
test/functional/page_objects/visual_builder_page.ts
if (browser.isFirefox) {
// https://github.com/elastic/kibana/issues/24058
await PageObjects.common.sleep(2000);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was fixed so I decided to remove it

@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v7.3.3 v7.4.1 v8.0.0 labels Sep 18, 2019
@dmlemeshko dmlemeshko marked this pull request as ready for review September 18, 2019 14:42
spalger
spalger approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after one small change

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko merged commit b9497fe into elastic:master Sep 18, 2019
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 18, 2019
@dmlemeshko
Fix/tsvb functional tests (elastic#45868)
c9a7639 
* [page_objects/visual_builder_page] increase timeout & remove FF sleep

* unskip flaky test suites

* run ciGroup6 12x times

* fix tsvb_markdown tests

* skip aggs test

* fix waiting

* run FF tests 8x times

* Revert "run FF tests 8x times"

This reverts commit 75ef2ce.

* Revert "run ciGroup6 12x times"

This reverts commit 217dbb8.

* Update test/functional/page_objects/visual_builder_page.ts

review fix

Co-Authored-By: Spencer <[email protected]>
@dmlemeshko dmlemeshko mentioned this pull request Sep 18, 2019
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 18, 2019
@dmlemeshko
Fix/tsvb functional tests (elastic#45868)
f23641e 
* [page_objects/visual_builder_page] increase timeout & remove FF sleep

* unskip flaky test suites

* run ciGroup6 12x times

* fix tsvb_markdown tests

* skip aggs test

* fix waiting

* run FF tests 8x times

* Revert "run FF tests 8x times"

This reverts commit 75ef2ce.

* Revert "run ciGroup6 12x times"

This reverts commit 217dbb8.

* Update test/functional/page_objects/visual_builder_page.ts

review fix

Co-Authored-By: Spencer <[email protected]>
@dmlemeshko dmlemeshko mentioned this pull request Sep 18, 2019
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 18, 2019
@dmlemeshko
Fix/tsvb functional tests (elastic#45868)
304365b 
* [page_objects/visual_builder_page] increase timeout & remove FF sleep

* unskip flaky test suites

* run ciGroup6 12x times

* fix tsvb_markdown tests

* skip aggs test

* fix waiting

* run FF tests 8x times

* Revert "run FF tests 8x times"

This reverts commit 75ef2ce.

* Revert "run ciGroup6 12x times"

This reverts commit 217dbb8.

* Update test/functional/page_objects/visual_builder_page.ts

review fix

Co-Authored-By: Spencer <[email protected]>
@dmlemeshko dmlemeshko mentioned this pull request Sep 18, 2019
Merged
dmlemeshko added a commit that referenced this pull request Sep 18, 2019
@dmlemeshko
Fix/tsvb functional tests (#45868) (#46047)
5282c9f 
* [page_objects/visual_builder_page] increase timeout & remove FF sleep

* unskip flaky test suites

* run ciGroup6 12x times

* fix tsvb_markdown tests

* skip aggs test

* fix waiting

* run FF tests 8x times

* Revert "run FF tests 8x times"

This reverts commit 75ef2ce.

* Revert "run ciGroup6 12x times"

This reverts commit 217dbb8.

* Update test/functional/page_objects/visual_builder_page.ts

review fix

Co-Authored-By: Spencer <[email protected]>
dmlemeshko added a commit that referenced this pull request Sep 18, 2019
@dmlemeshko
Fix/tsvb functional tests (#45868) (#46073)
4f3a949 
* [page_objects/visual_builder_page] increase timeout & remove FF sleep

* unskip flaky test suites

* run ciGroup6 12x times

* fix tsvb_markdown tests

* skip aggs test

* fix waiting

* run FF tests 8x times

* Revert "run FF tests 8x times"

This reverts commit 75ef2ce.

* Revert "run ciGroup6 12x times"

This reverts commit 217dbb8.

* Update test/functional/page_objects/visual_builder_page.ts

review fix

Co-Authored-By: Spencer <[email protected]>
dmlemeshko added a commit that referenced this pull request Sep 18, 2019
@dmlemeshko
Fix/tsvb functional tests (#45868) (#46071)
42357cf 
* [page_objects/visual_builder_page] increase timeout & remove FF sleep

* unskip flaky test suites

* run ciGroup6 12x times

* fix tsvb_markdown tests

* skip aggs test

* fix waiting

* run FF tests 8x times

* Revert "run FF tests 8x times"

This reverts commit 75ef2ce.

* Revert "run ciGroup6 12x times"

This reverts commit 217dbb8.

* Update test/functional/page_objects/visual_builder_page.ts

review fix

Co-Authored-By: Spencer <[email protected]>
@dmlemeshko
Copy link
Member Author

backported
7.x 5282c9f
7.4 42357cf
7.3 4f3a949

@dmlemeshko dmlemeshko deleted the fix/tsvb-functional-tests branch January 31, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@maryia-lapata maryia-lapata Awaiting requested review from maryia-lapata

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.3.3 v7.4.1 v8.0.0
Projects
None yet
Milestone
No milestone
3 participants
@dmlemeshko @elasticmachine @spalger