Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Update navigation tests to handle main and sub tabs #45793

Merged
merged 6 commits into from
Sep 20, 2019

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Sep 16, 2019

After ML navigation changes (#45220), this PR updates the navigation tests to handle and validate the new main and sub tabs.

@pheyos pheyos requested a review from a team as a code owner September 16, 2019 16:03
@pheyos pheyos self-assigned this Sep 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@pheyos pheyos removed the v7.4.0 label Sep 18, 2019
@pheyos
Copy link
Member Author

pheyos commented Sep 18, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@pheyos
Copy link
Member Author

pheyos commented Sep 20, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pheyos pheyos merged commit e8d99b7 into elastic:master Sep 20, 2019
@pheyos pheyos deleted the navigation_test_updates branch September 20, 2019 15:06
pheyos added a commit to pheyos/kibana that referenced this pull request Sep 20, 2019
This PR updates the navigation tests to handle and validate the new main and sub tabs.
pheyos added a commit that referenced this pull request Sep 20, 2019
…6242)

This PR updates the navigation tests to handle and validate the new main and sub tabs.
@pheyos pheyos mentioned this pull request Sep 23, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants