[7.x] Console to NP ready (#43346) #45511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* General structure of Public w/ legacy brace + autocomplete 🤔 Refactor Resizer functionality (panel component) Refactor Play Button Refactor Auto-completion Refactor Docs opener Refactor Storage * First refactor of kbn ace keyboard mode to TS+React * clean up unused props * console_menu.js -> console_menu.tsx * Remove unused file from quarantine and added fixed ui ace keyboard mode react hook * - Refactored history and storage to app-wide services - Pre-emptive changes to tests - sense-history -> HistoryList - removed unused kbn top nav v2 component * A lot of cleanup, re-introduced editor resize checker, re-introduced history viewer as TS+React. `history` still needs refactoring. * First iteration of tap nav menu, with history toggle working * Lots of fixes Also moved over and integrated remaining three react components * Moved a lot of files around again, tidied up NP set up * Replace angular directive * Remove used code * Re-order imports and move all ace dependencies to same location * Remove more unused code * Revise quarantined setup mocks * Don't suggest 'undefined' or other null-like values in autocomplete * Clean up api_server folder * Re-add missing style * Updated karma spec mock * Fix editors cutting of at bottom of screen * Refactor console editors into single components Refactor a lot of business logic to main.tsx container Minor renaming of variables for better readability * Updated use of contexts with better error message Fixed broken render sync cycles (using useCallback) Fixed Main container render cycle (added missing deps to useEffect) Fixed default input and removed auto indent from being called on init for already formatted text * Updated test mocks * Update to be more in line with NP conventions https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md * Update console history when making new requests Fixed spacing between editor and console history Moved registration of keyboard commands to TS Fixed setup_mocks.js after renaming app to application * Clean up git merge conflict artifact * Use updated NP interfaces * More typings fixed after updating local project dependencies * Removing some dependencies on KUI and font awesome from legacy editor * Fix clear history not re-rendering Refactor prop name to be more descriptive * Simplify split_panel and add tests * Fix accessibility tabbing behaviour for ace editor * Refactor ConsoleEditor into two separate components Remove unused changeCursor code Remove unused textArea ref Use default lodash debounce (remove unnecessary arg) * Major a11y fix when tabbing Major fix for ace in IE11 and Edge browsers * Update comment
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: