[ILM] Delete min_age field if warm phase on rollover is enabled #45412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
bug
|
Pinging @elastic/es-ui |
|
FYI @bmcconaghy |
💚 Build Succeeded |
cjcenizal
approved these changes
Sep 11, 2019
cjcenizal
reviewed
Sep 11, 2019
| delete esPhase.min_age; | ||
| } | ||
|
|
||
| {esPhase.actions = esPhase.actions || {};} |
There was a problem hiding this comment.
Sorry, actually, I just noticed this. Why is this wrapped in braces?
There was a problem hiding this comment.
Strange! That was not intentional. Thanks for catching this! I removed it and did some quick manual testing again to verify everything is still working as expected.
💚 Build Succeeded |
This was referenced Sep 12, 2019
alisonelizabeth
added a commit
to alisonelizabeth/kibana
that referenced
this pull request
Sep 12, 2019
alisonelizabeth
added a commit
that referenced
this pull request
Sep 12, 2019
alisonelizabeth
added a commit
that referenced
this pull request
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in ILM where a user was not able to successfully enable
Move to warm phase on rolloverin edit mode after previously having this disabled.Fixes #39328
Testing
Steps to reproduce are outlined in the issue. You will need to specify node attributes when you start up ES.
Release notes
Previously, a user was unable to successfully enable the
Move to warm phase on rolloversetting when editing an index lifecycle policy that previously had this setting disabled. This change fixes the issue.