-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][uptime] Move uptime guide to shared versions #45378
Conversation
Pinging @elastic/uptime |
Hey @bmorelli25 - regarding testing this PR, is there anything needed besides building the docs and making sure everything looks good? |
Good question. A successful doc build that shows 0 related changes in HTML diff is all that's needed in this case. Honestly, I don't think you even need to build this locally. The ci-docs build is sufficient... Although it appears to be down right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested by building locally and running, docs look good.
Code changes seem fine as well.
This PR changes how documentation version updates are applied to the Uptime monitoring guide. Before this PR, I'd update the documentation version in version.asciidoc for each release. It's not time consuming, but it is prone to errors. After this PR, the Uptime monitoring guide will take advantage of the shared version file in the docs repo.
Relevant discussion in elastic/docs#804.
[skip-ci]