Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][uptime] Move uptime guide to shared versions #45378

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

bmorelli25
Copy link
Member

This PR changes how documentation version updates are applied to the Uptime monitoring guide. Before this PR, I'd update the documentation version in version.asciidoc for each release. It's not time consuming, but it is prone to errors. After this PR, the Uptime monitoring guide will take advantage of the shared version file in the docs repo.

Relevant discussion in elastic/docs#804.

[skip-ci]

@bmorelli25 bmorelli25 added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes labels Sep 11, 2019
@bmorelli25 bmorelli25 self-assigned this Sep 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@justinkambic
Copy link
Contributor

Hey @bmorelli25 - regarding testing this PR, is there anything needed besides building the docs and making sure everything looks good?

@bmorelli25
Copy link
Member Author

bmorelli25 commented Sep 12, 2019

Good question. A successful doc build that shows 0 related changes in HTML diff is all that's needed in this case.

Honestly, I don't think you even need to build this locally. The ci-docs build is sufficient... Although it appears to be down right now.

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested by building locally and running, docs look good.
Code changes seem fine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants