[Graph] EUI-ification of search bar #45351
Conversation
flash1293
added
release_note:enhancement
Feature:Graph
💚 Build Succeeded |
💚 Build Succeeded |
I will! |
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
It still feels like such an uneccesary tight spot. Since it's the exact same UI, I would just continue to use the modal instead. |
|
@cchaos as discussed offline, I changed it to always use the modal. |
|
@cchaos it's more of a comment about the visuals— the underscore at the bottom of the search field feels a bit like a progress bar during the animation, while the real progress bar upon searching is on the very top of the screen (I like that the progress bar is subtle; resembles the image loading bars in Front row to Fashion Week though could maybe be slightly more prominent). Maybe the field selection signal outcompetes the real progress bar for the user's grasp of what's a progress bar (IOW the field selection underline stays solid upon search and the user may think it was instantaneous). Feels like this specific type of field selection animation was designed for shorter fields, and/or ones that don't trigger a wait time.
|
|
In reference to the search input, that's how all our inputs behave for the focus state it's just way more pronounced on such a wide input because the animation has much further to go. The progress indicator at the top of the page should actually be replaced with the search input's own
|
💔 Build Failed |
It's showing both currently. I think the progress indicator at the top of the page is a low level thing that will be removed once I move the data fetching over in a separate PR. |
💚 Build Succeeded |
💚 Build Succeeded |
Summary
Related #44103
This PR moves the search bar and the index pattern picker to React and Typescript. Additionally a modal to pick the initial index pattern is shown when a new workspace is opened. Both modal and popover use the shared
SavedObjectFindercomponent. This will get more helpful in the future when saved searches can also be picked as data source.The vertex manager is not changed in this PR, this will be done separately.
App arch reviewer
I slightly extended the API of
SavedObjectFinderto also return the actual saved object instance instead of just the id. This avoids an additional lookup of the saved object and will make it possible to not fetch the list of all index patterns in Graph in a further refactoring PR.It's a bit ugly that the
onChoosecallback now provides four parameters - if you feel strongly about this I can also clean up the existing usages with a nicer API.