Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Data frame transform: Fix progress in wizard create step. (#45116) #45240

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

walterra
Copy link
Contributor

Backports the following commits to 7.x:

…ic#45116)

Fixes a regression where the progress bar in the transform wizard would return to 0% after a transform finishes.

The actual bugfix is just the code in 6033a4c to make sure the code in the wizard uses the same function getTransformProgress() like the transform management page. Also includes a fix for sorting on the transform list table related to progress.

The rest of the diff is a) moving types and utility functions previously only used within the transform management page to the common shared code of data frame transforms so it's available for the wizard without cross-deep-importing (717d894) and b) adding tests with updated mock data (f14e231).
@walterra walterra self-assigned this Sep 10, 2019
@walterra walterra added the :ml label Sep 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@walterra
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit 9a2d8d6 into elastic:7.x Sep 10, 2019
@walterra walterra deleted the backport/7.x/pr-45116 branch September 10, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants