Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding job_type to job messages search #45121

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 9, 2019

Updates job messages search to reflect changes that will be made in elastic/elasticsearch#45967.

Changes index pattern to be .ml-notifications*
Updates the search used to match on job_type: 'anomaly_detector' or if job_type isn't present at all.
If job_type isn't present, this is a version of the .ml-notifications which predates the changes made in elastic/elasticsearch#45967

@jgowdyelastic jgowdyelastic self-assigned this Sep 9, 2019
@jgowdyelastic jgowdyelastic added :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review labels Sep 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic marked this pull request as ready for review September 9, 2019 12:23
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 9, 2019 12:23
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
}
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need the addition of "minimum_should_match":1 I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in 65b0372

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit b7aeaf5 into elastic:master Sep 9, 2019
@jgowdyelastic jgowdyelastic deleted the adding-job_type-to-job-messages-search branch September 9, 2019 16:42
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 9, 2019
* [ML] Adding job_type to job messages search

* adding minimum_should_match
jgowdyelastic added a commit that referenced this pull request Sep 10, 2019
* [ML] Adding job_type to job messages search

* adding minimum_should_match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants