-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adding job_type to job messages search #45121
[ML] Adding job_type to job messages search #45121
Conversation
Pinging @elastic/ml-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need the addition of "minimum_should_match":1
I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in 65b0372
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡️
💚 Build Succeeded |
* [ML] Adding job_type to job messages search * adding minimum_should_match
Updates job messages search to reflect changes that will be made in elastic/elasticsearch#45967.
Changes index pattern to be
.ml-notifications*
Updates the search used to match on
job_type: 'anomaly_detector'
or ifjob_type
isn't present at all.If
job_type
isn't present, this is a version of the.ml-notifications
which predates the changes made in elastic/elasticsearch#45967