[SIEM] Inject/apply KQL changed in refresh button #45065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem |
XavierM
force-pushed
the
siem-refresh-kql
branch
from
c1e3224 to
6b503bd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
XavierM
force-pushed
the
siem-refresh-kql
branch
from
15304cc to
34597a8
Compare
💚 Build Succeeded |
x-pack/legacy/plugins/siem/public/components/super_date_picker/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
force-pushed
the
siem-refresh-kql
branch
from
34597a8 to
0f89333
Compare
This comment has been minimized.
This comment has been minimized.
x-pack/legacy/plugins/siem/public/components/super_date_picker/index.tsx
Outdated
Show resolved
Hide resolved
| useUpdateKql({ | ||
| indexPattern: mockIndexPattern, | ||
| kueryFilterQuery: { expression: '', kind: 'kuery' }, | ||
| kueryFilterQueryDraft: { expression: 'host.name: "myLove"', kind: 'kuery' }, |
stephmilovic
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Performed code review, browser tests, and cypress testing (url state). I think it would be good to add a cypress test for this, ensure the url gets updated when updating via refresh click. Other than that, fix the jest failures and an optional nit comment, LGTM 🚀
x-pack/legacy/plugins/siem/public/components/timeline/timeline.tsx
Outdated
Show resolved
Hide resolved
XavierM
force-pushed
the
siem-refresh-kql
branch
from
0f89333 to
9f375b5
Compare
x-pack/legacy/plugins/siem/public/components/timeline/fetch_kql_timeline.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/timeline/timeline_context.tsx
Outdated
Show resolved
Hide resolved
andrew-goldstein
approved these changes
Sep 11, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Sep 11, 2019
* wip to apply kql when refresh on hosts page * refactor to have less re-render * add network and timeline page * fix/add unit testing * from review remove any effect from render * clean up + review II * review II + bug fixes * review III
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Sep 11, 2019
* wip to apply kql when refresh on hosts page * refactor to have less re-render * add network and timeline page * fix/add unit testing * from review remove any effect from render * clean up + review II * review II + bug fixes * review III
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176)
XavierM
added a commit
that referenced
this pull request
Sep 11, 2019
* wip to apply kql when refresh on hosts page * refactor to have less re-render * add network and timeline page * fix/add unit testing * from review remove any effect from render * clean up + review II * review II + bug fixes * review III
XavierM
added a commit
that referenced
this pull request
Sep 11, 2019
* wip to apply kql when refresh on hosts page * refactor to have less re-render * add network and timeline page * fix/add unit testing * from review remove any effect from render * clean up + review II * review II + bug fixes * review III
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…ditor * 'master' of github.com:elastic/kibana: (76 commits) Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inject/apply KQL changed in refresh button
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately