Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Create developer guide part #44954

Merged
merged 2 commits into from
Sep 6, 2019
Merged

[DOCS] Create developer guide part #44954

merged 2 commits into from
Sep 6, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 5, 2019

Summary

Related to #44907

This PR takes the following part of the Kibana guide: https://www.elastic.co/guide/en/kibana/master/development.html
... and renames it from "Contributing to Kibana" to "Developer guide".

It also moves the first page of that part from https://github.com/elastic/kibana/tree/master/docs to https://github.com/elastic/kibana/tree/master/docs/development

An open question is whether or not the "development" folder should be renamed to "dev" or "developer".

[skip ci]

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

@lcawl lcawl added Team:Docs WIP Work in progress v8.0.0 labels Sep 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@gchaps gchaps mentioned this pull request Sep 5, 2019
13 tasks
@lcawl
Copy link
Contributor Author

lcawl commented Sep 5, 2019

@lcawl lcawl removed the WIP Work in progress label Sep 6, 2019
@lcawl lcawl marked this pull request as ready for review September 6, 2019 20:06
@lcawl lcawl requested review from gchaps and KOTungseth September 6, 2019 20:07
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Sep 6, 2019
@lcawl lcawl merged commit 745f3d1 into elastic:master Sep 6, 2019
@lcawl lcawl deleted the dev-guide branch September 6, 2019 20:51
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 6, 2019
@lcawl lcawl added the v7.5.0 label Sep 6, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 6, 2019
@lcawl lcawl added the v7.4.1 label Sep 6, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 6, 2019
@lcawl lcawl added the v7.3.2 label Sep 6, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 6, 2019
@lcawl lcawl added the v7.2.2 label Sep 6, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants